From: Ihor Radchenko <firstname.lastname@example.org> To: Bastien <email@example.com> Cc: Org Mode <firstname.lastname@example.org>, John Kitchin <email@example.com> Subject: Re: [QUESTION] What's the ":desk" link parameter? Date: Tue, 02 Jun 2020 21:22:12 +0800 [thread overview] Message-ID: <87pnah38mz.fsf@localhost> (raw) In-Reply-To: <firstname.lastname@example.org> > I'm not sure `org-link-make-description-function' is used a lot out > there, but the change may break existing configurations/hacks. It should not break anything. I did not remove `org-link-make-description-function' functionality. Just marked it as deprecated. > Also, is it something we could use in the current export backends > or just for the users? If the latter, then I'm in favor of making > this move, probably for 9.5. I am not very familiar with the export code, but the function provided in :description property should follow the same conventions with `org-link-make-description-function'. The only place it is used is org-insert-link. I do not see how it can influence export code. As I understand, org-insert-link is mostly for users. Best, Ihor Bastien <email@example.com> writes: > Hi Ihor, > > Ihor Radchenko <firstname.lastname@example.org> writes: > >>> thanks for the patch. I assume you are submitting it against master, >>> am I right? >> >> The patch is against commit 2e96dc639. > > I see, thanks. > >>> From reading this, I don't see what bug it fixes, what problem it >>> solves or what real user need it responds to, but maybe I lost part >>> of the context. Can you explain why this should be applied? >> >> It does not fix any bug. Rather adds a new feature . Currently, org >> provides org-link-make-description-function as user customisation to >> compute default link description. The patch provides a way to set such >> description functions on per link type basis (via :description link >> parameter). Using link parameters looks natural for me since similar >> customisation is already done in :follow and :store link parameters. > > Okay, I understand. It feels natural to me too. > > I'm not sure `org-link-make-description-function' is used a lot out > there, but the change may break existing configurations/hacks. > > Also, is it something we could use in the current export backends > or just for the users? If the latter, then I'm in favor of making > this move, probably for 9.5. > > Nicolas, what do you think? > > -- > Bastien -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: email@example.com, firstname.lastname@example.org
next prev parent reply other threads:[~2020-06-02 13:27 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-23 12:23 stardiviner 2020-05-23 13:49 ` Bastien 2020-05-23 14:01 ` John Kitchin 2020-05-23 23:52 ` stardiviner 2020-05-24 3:10 ` Ihor Radchenko 2020-05-24 11:00 ` Bastien 2020-05-24 11:34 ` Ihor Radchenko 2020-06-02 12:29 ` Bastien 2020-06-02 13:22 ` Ihor Radchenko [this message] 2020-06-02 13:55 ` stardiviner 2020-05-24 11:12 ` stardiviner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87pnah38mz.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [QUESTION] What'\''s the ":desk" link parameter?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).