From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp2 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms11 with LMTPS
	id mChOMuntRV82NQAA0tVLHw
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 26 Aug 2020 05:06:49 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp2 with LMTPS
	id 6OMULuntRV9zBAAAB5/wlQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 26 Aug 2020 05:06:49 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 7F1C79402A0
	for <larch@yhetil.org>; Wed, 26 Aug 2020 05:06:48 +0000 (UTC)
Received: from localhost ([::1]:49310 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1kAne2-0002F5-CY
	for larch@yhetil.org; Wed, 26 Aug 2020 01:06:46 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49918)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <kyle@kyleam.com>) id 1kAnd2-0001jQ-Vn
 for emacs-orgmode@gnu.org; Wed, 26 Aug 2020 01:05:45 -0400
Received: from pb-smtp2.pobox.com ([64.147.108.71]:51826)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <kyle@kyleam.com>) id 1kAnd0-00085A-5g
 for emacs-orgmode@gnu.org; Wed, 26 Aug 2020 01:05:44 -0400
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
 by pb-smtp2.pobox.com (Postfix) with ESMTP id 722CC84525;
 Wed, 26 Aug 2020 01:05:39 -0400 (EDT) (envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
 :subject:in-reply-to:references:date:message-id:mime-version
 :content-type; s=sasl; bh=uR24p+z6jzryTwaarojwMwSnz1o=; b=nvZeF7
 FuKW99q7gBDRSwCzUYu0p6zDgPK2wzczMEsW38ANmTavuCPVE83yELU7ZiEZZjej
 N5qTbcjtaiBqe3hYntnD586yNkI2S7s9Dv1rezWQOb7lFhKlKHYteZazU06AQ6EW
 FrCA3qeHyL2ZIecK314bTtJ+imy/jjGnUgnU8=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
 by pb-smtp2.pobox.com (Postfix) with ESMTP id 6AA6B84524;
 Wed, 26 Aug 2020 01:05:39 -0400 (EDT) (envelope-from kyle@kyleam.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com;
 h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type;
 s=mesmtp; bh=XiU1p0zeavOLj+OaEMwWoUuehyDShs7VkqBbfIssmL0=;
 b=W6C/FLUj6C3wZfZhdbx/dhpEDPyuw6eCMjyduiKb/jooQqDGlwxL2fRxHFSV/ZUyi1PMw1xsCxF1POteKOwvBFX8SymKQv7+PGIENOtuunXewsTwMKaWzXZ7ZmoYnAunFLO+GwY3BguR8Sxa+4FuZhwtXJFuttGiiB3Upl2IqyE=
Received: from localhost (unknown [45.33.91.115])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by pb-smtp2.pobox.com (Postfix) with ESMTPSA id DB80D84522;
 Wed, 26 Aug 2020 01:05:38 -0400 (EDT) (envelope-from kyle@kyleam.com)
From: Kyle Meyer <kyle@kyleam.com>
To: Richard Kim <emacs18@gmail.com>
Subject: Re: patch to suppress "deprecated cl" warnings plus few others
In-Reply-To: <CAFq8O8v=x0PQKQBRsac81YiZoBb42HED_a=1F7Dzv2Dae-HZvg@mail.gmail.com>
References: <CAFq8O8v=x0PQKQBRsac81YiZoBb42HED_a=1F7Dzv2Dae-HZvg@mail.gmail.com>
Date: Wed, 26 Aug 2020 01:05:37 -0400
Message-ID: <87pn7em1y6.fsf@kyleam.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: C8705A6C-E759-11EA-8459-2F5D23BA3BAF-24757444!pb-smtp2.pobox.com
Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com;
 helo=pb-smtp2.pobox.com
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/26 01:05:39
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Scanner: scn0
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=pobox.com header.s=sasl header.b=nvZeF7 F;
	dkim=pass header.d=kyleam.com header.s=mesmtp header.b=W6C/FLUj;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org
X-Spam-Score: -1.21
X-TUID: AO7QwMJCWQxP

Richard Kim writes:

> Attached patch suppresses byte compiler warnings.

Thanks.  contrib/ doesn't receive much love when it comes to these sorts
of things, and byte-compiling its files is not a pretty sight.

> Subject: [PATCH] Suppressed all "deprecated cl" warnings plus few others.

A "contrib: " prefix on this subject would be useful for orienting log
readers.

Convention nit-pick: Drop the period from the subject.

> diff --git a/contrib/lisp/ob-tcl.el b/contrib/lisp/ob-tcl.el
> index 091eb5d09..d269ad38a 100644
> --- a/contrib/lisp/ob-tcl.el
> +++ b/contrib/lisp/ob-tcl.el
> @@ -31,7 +31,7 @@
>  ;;; Code:
>  (require 'ob)
>  (require 'ob-eval)
> -(eval-when-compile (require 'cl))
> +(eval-when-compile (require 'cl-lib))

The byte-compiler complains after your change:

    contrib/lisp/ob-tcl.el:129:1:Warning: the following functions are
        not known to be defined: case, output, value

These all come from a missed s/case/cl-case/.

>  (defvar org-babel-tangle-lang-exts)
>  (add-to-list 'org-babel-tangle-lang-exts '("tcl" . "tcl"))
> diff --git a/contrib/lisp/org-choose.el b/contrib/lisp/org-choose.el
> index c1006d095..799fd917f 100644
> --- a/contrib/lisp/org-choose.el
> +++ b/contrib/lisp/org-choose.el
> @@ -62,9 +62,7 @@
>  ;;; Requires
>  
>  (require 'org)
> -					;(eval-when-compile
> -					;   (require 'cl))
> -(require 'cl)
> +(require 'cl-lib)

Same applies here.  You took care of s/position/cl-position/ below, but
there are a good number of other symbols that now require a prefix:
defstruct, destructuring-bind, incf, pushnew, first, and second.

>  ;;; Body
>  ;;; The variables
> @@ -357,7 +355,7 @@ setting was changed."
>  (defun org-choose-get-index-in-keywords (ix all-keywords)
>    "Return the index of the current entry."
>    (if ix
> -      (position ix all-keywords
> +      (cl-position ix all-keywords
>  		:test #'equal)))
>

I haven't yet looked beyond the first two files, though I suspect the
other files may have similar issues.  Could you take a closer look and
send an updated patch?