From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qPpNIysyWV96YQAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 19:51:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MGyAHysyWV+VZAAAbx9fmQ (envelope-from ) for ; Wed, 09 Sep 2020 19:51:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29ED39406BB for ; Wed, 9 Sep 2020 19:51:07 +0000 (UTC) Received: from localhost ([::1]:57988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG67U-0001PH-UX for larch@yhetil.org; Wed, 09 Sep 2020 15:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG67A-0001Ou-38 for emacs-orgmode@gnu.org; Wed, 09 Sep 2020 15:50:44 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:52952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kG678-0008TT-GR for emacs-orgmode@gnu.org; Wed, 09 Sep 2020 15:50:43 -0400 Received: by mail-pj1-x1044.google.com with SMTP id o16so1865008pjr.2 for ; Wed, 09 Sep 2020 12:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=NihzWt9Kw9MW2JHIERLlvk+/XHJdfQuM0sHjtKc9AV8=; b=dmQJQWq1gBLRDFal+58MEYQ9Q0zZBmQnlOTakfp7wQA/+hAYSbCfUXxztDptF5lqU1 yzfK97lY/zGzqCwt/WYV86dwHzHl78oGh9A48nxUaJljFbOdnP/NMXD6S+xFyRD1Atqt Wq8KvypxR+cHb113FlfgiphWx3u2dfR2lXDOxjrnhY8JO8kLpqQWXbf9i7OCcz/mqhH7 5zMvsMlgD8hAwwooWbgat6pHm1IlCaJRbxFxv7BeliR+aWskMQ7jr1aq8QqKbRejmFh3 AgwNXtNpGXCakDdJ+RS9l25tAaNX8yYxOozskurH+ve8pkE2mq9McfJuroVrn3ekX4lb cw/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=NihzWt9Kw9MW2JHIERLlvk+/XHJdfQuM0sHjtKc9AV8=; b=c/GuFX8OyDkGWhS0Dz5jIqC6EC0TIqF/gEMNjn8sMVQOkm0my12fSvUCC/4vpe54y5 +bSpMxfSWAV5U4ZK9TYLjuLewA0OyXv6E4jl2h5OUQVyQ4z4mSbDKQtG3UqV7fwUzn2A yBZtjaZ2O/hQVxVZdnYLAxjqZTwOtpg/Xl8yX3IGpkvy1Nun7wZ4xE1zsDCHx+imP+sj M6UQQjjzULE7lgkMton6MoAxH9OItMPx4tHBtUwwbzRSq6iE32B4jRJiYVZg3KihzUdB +/t2V/KSTZXg8OG+SviEtL9Bx83tUt+/EpuF+OVtaPFJCclSo460OLWN33xsIuJIGUNv of9Q== X-Gm-Message-State: AOAM533o7K4PqSQ5j//7fxKAQCIT5/EpjG/Gyd/aArjoOONMr38V9UMf Gg5LI+fFmMK4elnz/oXDIvF6TefUXM5Rqg== X-Google-Smtp-Source: ABdhPJxXy5vweNib9IAQ1hc/p+N9V1KAZz9Qn3vyNWjilcI3X7MHAX3HU4m4kOvmlPpJM3HRzmzggw== X-Received: by 2002:a17:90a:414e:: with SMTP id m14mr2021200pjg.186.1599681040554; Wed, 09 Sep 2020 12:50:40 -0700 (PDT) Received: from ryzen3950 (c-73-71-89-135.hsd1.ca.comcast.net. [73.71.89.135]) by smtp.gmail.com with ESMTPSA id q190sm3575630pfc.176.2020.09.09.12.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 12:50:39 -0700 (PDT) From: Matt Huszagh To: Kyle Meyer Subject: Re: [PATCH] Omit file description when :file-desc has nil value In-Reply-To: <87r1rf35bb.fsf@kyleam.com> References: <87r1rf35bb.fsf@kyleam.com> Date: Wed, 09 Sep 2020 12:50:38 -0700 Message-ID: <87pn6uzq41.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1044; envelope-from=huszaghmatt@gmail.com; helo=mail-pj1-x1044.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , Emacs-Orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=dmQJQWq1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: RMoRBZuyBtDl Kyle Meyer writes: > I also don't find the current behavior particularly intuitive. (I'm > also not really a babel user, so my opinion probably shouldn't count for > much.) If we were adding it today, I think what you describe would be > better, but, as you mention, breakage also now also weighs against > making a change here. > > In any case, I'd suggest raising the discussion on the list after the > 9.4 release. Ok, I'll follow up on this then. >>> Right, to reflect the current behavior established as a result of the >>> above thread, I think that should be reworded to distinguish between an >>> absent :file-desc header and one with no argument. Sorry for not >>> catching that when reviewing your initial patch. >> >> No worries, and I agree the documentation should be updated. I'm happy >> to provide the patch myself, but I'd like to talk through whether the >> current implementation is the correct one before I do. > > Thanks. To avoid any confusion coming from this description making it > into the 9.4 release, I've updated it in 4b2123fb7. Thanks for fixing that Kyle. Matt