From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AJcvLyFEfF9tEgAA0tVLHw (envelope-from ) for ; Tue, 06 Oct 2020 10:17:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iCdIKyFEfF/cHAAAbx9fmQ (envelope-from ) for ; Tue, 06 Oct 2020 10:17:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 437269402B4 for ; Tue, 6 Oct 2020 10:17:05 +0000 (UTC) Received: from localhost ([::1]:40700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPk1m-0004hB-Sb for larch@yhetil.org; Tue, 06 Oct 2020 06:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPk11-0004gC-LQ for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 06:16:16 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:50971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPk0z-0006Q6-Ad for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 06:16:15 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id ACCB61C0002; Tue, 6 Oct 2020 10:16:08 +0000 (UTC) From: Nicolas Goaziou To: this nkk Subject: Re: Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)] References: <86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me> Mail-Followup-To: this nkk , emacs-orgmode@gnu.org Date: Tue, 06 Oct 2020 12:15:56 +0200 In-Reply-To: <86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me> (this nkk's message of "Thu, 24 Sep 2020 17:16:24 -0700") Message-ID: <87pn5vu0bn.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.197; envelope-from=mail@nicolasgoaziou.fr; helo=relay5-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/06 06:16:09 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: S1zpmw+qECqv Hello, this nkk writes: > when running org-id-find-id-in-file on an id and an unvisited file, the > buffer it creates to visit file isn't > closed after finding id. > > ** what should have happened > I was expecting it to close the buffer if the > file wasn't already visited by another buffer. > > Is this desired behavior? It depends. If MARKERP is non-nil, you certainly don't want to close the newly created buffer. Otherwise, it could be closed, indeed. I patched master along these lines. Thank you. Regards, -- Nicolas Goaziou