emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Dieter Faulbaum <mail@faulbaum.in-berlin.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] repeat cookies should be in the same order as the repeats
Date: Tue, 10 Nov 2020 00:49:26 -0500	[thread overview]
Message-ID: <87pn4llq1l.fsf@kyleam.com> (raw)
In-Reply-To: <20201104143540.29602-1-mail@faulbaum.in-berlin.de>

Thanks for the patch.

> [PATCH] repeat cookies should be in the same order as the repeats

Convention nit: Ideally this subject would start with a "scope/file:",
e.g. "manual:" or "org-manual.org:".

Also, could you please add a changelog entry and TINYCHANGE cookie, as
described at <https://orgmode.org/worg/org-contribute.html>?

Dieter Faulbaum writes:

> ---
>  doc/org-manual.org | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/doc/org-manual.org b/doc/org-manual.org
> index ef2dad9ef..e78690993 100644
> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -5741,6 +5741,7 @@ expressions to process these values before inserting them into a table
>  or a dynamic block.
>  * Dates and Times
> +
>  :DESCRIPTION: Making items useful for planning.
>  :END:

Please drop this unrelated change.

> @@ -6281,7 +6282,7 @@ organize such tasks using a so-called repeater in a =DEADLINE=,
>  the =+1m= is a repeater; the intended interpretation is that the task
>  has a deadline on =<2005-10-01>= and repeats itself every (one) month
>  starting from that time.  You can use yearly, monthly, weekly, daily
> -and hourly repeat cookies by using the =y=, =w=, =m=, =d= and =h=
> +and hourly repeat cookies by using the =y=, =m=, =w=, =d= and =h=
>  letters.  If you need both a repeater and a special warning period in
>  a deadline entry, the repeater should come first and the warning
>  period last

Good catch.  Thanks.

  reply	other threads:[~2020-11-10  5:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 14:35 [PATCH] repeat cookies should be in the same order as the repeats Dieter Faulbaum
2020-11-10  5:49 ` Kyle Meyer [this message]
2020-11-20  4:16   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn4llq1l.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@faulbaum.in-berlin.de \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).