From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id jiNkH3AgsF/KJwAA0tVLHw (envelope-from ) for ; Sat, 14 Nov 2020 18:22:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qFMHG3AgsF96GwAAB5/wlQ (envelope-from ) for ; Sat, 14 Nov 2020 18:22:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B24619403AB for ; Sat, 14 Nov 2020 18:22:39 +0000 (UTC) Received: from localhost ([::1]:55830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ke0C5-0004eG-6p for larch@yhetil.org; Sat, 14 Nov 2020 13:22:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke0BT-0004dk-SR for emacs-orgmode@gnu.org; Sat, 14 Nov 2020 13:22:00 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:62213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke0BR-0007MI-Hs for emacs-orgmode@gnu.org; Sat, 14 Nov 2020 13:21:59 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 96BEB8429C; Sat, 14 Nov 2020 13:21:54 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=B9OhVrGcGPpfkCScOFI5CRUqodo=; b=OgCuMH 5S6Hlf0kLguoX4O5rgxOC8Q7fCRttGL5cv73KQjDBqqYOYaW4XCBYcDxJazRNaSo cS0IXCezBY+TH+bbQsYO+KvccFf47q2cOkU9bpfD5TaWcTbM5p3yz0pMFp1JVZA1 gV4R8RKKjRsf7+tJLMzMv1iZITUknSm8IiCFs= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8E0288429B; Sat, 14 Nov 2020 13:21:54 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=RGQ6hzRabiGJ3+8J1JK7dC2/2cAlL3NmEz+1bJPJFo4=; b=HQcVfFqoh5WHjUA6jD5UV5lj3T2qjlsqhDeihXXtHW8MpYBNkmIelOITOQlK8L4z8u4oT1V5DIqG3+jWoAJCLlglVpuGiYdkXd8gMaWc1oCwfiFLgs+Vlikx276NdhIFZiRvJ0ydP+ZTIMvfw7inLeb0HO8XsgjSQRm2D07F/aQ= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 0DD4A8429A; Sat, 14 Nov 2020 13:21:54 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: ian martins Subject: Re: [PATCH] ob-java.el: Allow for more whitespace In-Reply-To: References: <87d00h7wbr.fsf@kyleam.com> Date: Sat, 14 Nov 2020 13:21:53 -0500 Message-ID: <87pn4f6bpa.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 45B3E9F4-26A6-11EB-85FC-74DE23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 13:21:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=OgCuMH 5; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=HQcVfFqo; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: KWadS4x+Z8um ian martins writes: > On Thu, Nov 12, 2020 at 10:46 PM Kyle Meyer wrote: >> Is this related to Jarmo's report at >> ? If so, it'd be good >> to include a Reported-by trailer as well as a link. > > Yes. The updated patch includes Reported-by. That is just text in the > commit message, not a git option, right? Correct, it's just the block at the end of the commit message. If you use Magit's git-commit.el, there are some helpers for inserting common trailers, including git-commit-reported ('C-c C-p'). The main thing is that the information is there in some form, so everything that follows next is very much in the "doesn't really matter" territory... I've recently tried to be more consistent with the format I use. In particular, giving the link a keyword rather than putting a plain value underneath: Reported-by: Name Ref: link My reason for this is that Git does have a concept of what a trailer is (see 'man git-interpret-trailers'). Without the "Ref:" (or some other keyword), the link is seen as part of the Reported-by value if the link has indentation. Without indentation, the Reported-by is no longer seen as a trailer. And with Git 2.29, I've become a little more interested in Git being able to parse these because shortlog learned "--group=trailer:". For example $ git shortlog -s --group=trailer:reported-by release_9.4.. | head -3 1 Allen Li 1 B Goodr 1 Charles Tam I think that's kind of neat, but again doesn't really matter :) Thanks for the updates.