From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mGrNG9QNQWPNmgAAbAwnHQ (envelope-from ) for ; Sat, 08 Oct 2022 07:42:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MF3ZG9QNQWOk/QAA9RJhRA (envelope-from ) for ; Sat, 08 Oct 2022 07:42:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B52427C52 for ; Sat, 8 Oct 2022 07:42:44 +0200 (CEST) Received: from localhost ([::1]:39354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh2bj-00035u-5X for larch@yhetil.org; Sat, 08 Oct 2022 01:42:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh2az-00034a-6J for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 01:41:57 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:64728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh2aw-00066H-4J for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 01:41:56 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1665207711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTKIVYiyOMZL3WsrlLpq7oKBqPusxla4WUwH3o2Jr5A=; b=t3mMSGyEe9CoQcCVSOn9SHVF6jnOU8UwZnRiteAJuIWN79EEP3sxKKwnKE3iQTI1tTlqov JmIMuKIMe2K89T3fp8wcYpsrGpmK3Za4BWvyXo+HFsqNLxiwv2ptPyEqTs8Pu2MaemoInN q+3OUgvu1KiWInGRzdnJm2RRNPhpiJ8+CLKHocA3oON/CCaVEb8JE620JXVXBTLfcHN7rG NZhqAYRwxijAui8c0P7K8n9omVwH82vLRPVWw3k/lxzbHuB9Z8zJyn1jEqy42qnvKURzgF +eyBkhZpHjtQeNw16J6W58M3CxvLdvraZV14+gA31hTmPMz0/NYkbfq+Vq76Eg== From: Kyle Meyer To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [BUG] Re: 98e168b48 Add compatibility wrapper for string-clean-whitespace (Emacs 26 compatibility) [9.6-pre (release_9.5.5-920-g057193 @ /home/yantar92/.emacs.d/straight/build/org/)] In-Reply-To: <87o7umlxd5.fsf@localhost> References: <8735c01aho.fsf@localhost> <87wn9baby0.fsf@kyleam.com> <87o7umlxd5.fsf@localhost> Date: Sat, 08 Oct 2022 01:41:50 -0400 Message-ID: <87pmf2an35.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665207764; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lTKIVYiyOMZL3WsrlLpq7oKBqPusxla4WUwH3o2Jr5A=; b=L13cAjocOELrg/bUJcKdfmoMghGk6m3MAMi3+Bh1AViPtRBFSxKwdxLvaEmzlPp1jlD5DZ ljSGL2BbdfvtEME9QTZrBkM33cytHazL+ZffXFDtPVBj3VeIRrhFS57ZAoSydfYtZW5AUK emTLDBqzloh+mN9jEbgT9foU+Cojbgj6dj3+CdXQMMGYhK5TjAJzU0cPgjXl+C1pLp67a+ TR5rPkBMDh+s3usrp9dwN9sUYTWnng9IWA3FxVFUAEQ4ei8P2A7NN7g/JMnZW3cp/JVN5r 9GNb4fwXU9WVtptp46iaZj7/jcnaIi5sfYHNoGhMh/alRflf4Awxp0BzaZX6Cg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665207764; a=rsa-sha256; cv=none; b=HznQxfKrd6lxGLh7wc0hovISWoiVAhO7Ss0xq4Ar7cRL36Rt90v6GaDhu/7r8XXhMGsx3g GUjYtWUyjx9CL/YwlXJ8oDtJ5c6bj9kV7H+72Kl0uYL43HFKYIMj8DxsjeFRcMW3NSs6lR gWNSKWKp8wMeepZWK19dE2vpvROW81Ma/CnY8psaJf9u/Vb9H8IZ2ekJgHp1G7+v3BMEFh pOkEbBRl084riSj6iZkLTavn+sjCx4nts/4Kie4ztZMzUJhWLiwXMI8UpKpo1X2R8zb/7K GjfrUKJzDqRYrHf88GkJsrqichhrhwhBKd9I5deFesBhGU7Tu2Su8ZDg2iIKGA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=t3mMSGyE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.38 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=t3mMSGyE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1B52427C52 X-Spam-Score: -3.38 X-Migadu-Scanner: scn1.migadu.com X-TUID: /YnNaJVe+rbD Ihor Radchenko writes: > I do recall Nicolas repeatedly voicing against usage of subr-x staff: > > https://orgmode.org/list/87wo4en8qk.fsf@nicolasgoaziou.fr >>>> 2. we don't use "subr-x.el" in the code base. In particular, it would be >>>> nice to replace `when-let' with `when' + `let'. This change costs >>>> only one loc. > > However, he did not mention the reasoning behind this, except a single > massage I was able to find: > > https://orgmode.org/list/8737t0b2c9.fsf@nicolasgoaziou.fr >>>> ... you are not using `if-let' anywhere if this patch. Besides, we still >>>> cannot use subr-x, since it is a 24.4 library, and, AFAIR, we didn't >>>> drop support for 24.3 yet. > > If supporting Emacs 24 is the only blocker for subr-x, it should be safe > to use it. Right, as far as I understand, support for Emacs 24.3 was the main reason to avoid it; subr-x.el wasn't added until Emacs 24.4, when it was renamed from helpers.el. (There may be the general stylistic question of whether to use when-let{,*} and friends, but that's not relevant in this context.) I've pushed 04d9d4b3d, but please feel free to adjust as needed if some other reason to avoid loading subr-x surfaces.