Re: Feature request: skip blocked lines in agenda view grid

From: Michael Ekstrand <michael@elehack.net>
To: emacs-orgmode@gnu.org
Subject: Re: Feature request: skip blocked lines in agenda view grid
Date: Tue, 21 Oct 2008 08:21:40 -0500	[thread overview]
Message-ID: <87od1exevv.fsf@elehack.net> (raw)
In-Reply-To: 37C80D01-A50E-4D29-898F-1F2B3E4E50C8@uva.nl

[-- Attachment #1.1: Type: text/plain, Size: 2887 bytes --]

Carsten Dominik <dominik@uva.nl> writes:
> you have just catapulted yourself onto the list of possible successors
> when I will quit as maintainer of Org...  :-)
>
> Good work - I don't think it works completely yet, though.

Thanks :)

> When I have
>
> * new one
>   <2008-10-21 Tue 08:01-11:55>
>
> * new two
>   <2008-10-21 Tue 13:59-14:55>
>
> Then I get this agenda:
>
> Day-agenda (W43):
> Tuesday    21 October 2008
>                8:00......  ----------------
>   past:        8:01-11:55  new one
>               11:00......  ----------------
>               12:00......  ----------------
>               13:00......  ----------------
>   past:       13:59-14:55  new two
>               15:00......  ----------------
>               16:00......  ----------------
>               17:00......  ----------------
>               18:00......  ----------------
>               20:00......  ----------------
>
> The line at 11:00 should be gone as well.

I think I've found the problem.  I was computing the end time by adding
minutes to start time, which doesn't quite work for obvious reasons.
I've fixed it in the following code.

(defadvice org-agenda-add-time-grid-maybe (around mde-org-agenda-grid-tweakify
                                                  (list ndays todayp))
  (if (member 'remove-match (car org-agenda-time-grid))
      (flet ((extract-window
              (line)
              (let ((start (get-text-property 1 'time-of-day line))
                    (dur (get-text-property 1 'duration line)))
                (cond
                 ((and start dur) (cons start dur))
                 (start start)
                 (t nil))))
             (duration-add
              (time duration)
              (+ time (* 100 (/ duration 60)) (% duration 60))))
        (let* ((windows (delq nil (mapcar 'extract-window list)))
               (org-agenda-time-grid
                (list (car org-agenda-time-grid)
                      (cadr org-agenda-time-grid)
                      (remove-if
                       (lambda (time)
                         (find-if (lambda (w)
                                    (if (numberp w)
                                        (equal w time)
                                      (and (>= time (car w))
                                           (< time (duration-add
                                                    (car w) (cdr w))))))
                                  windows))
                       (caddr org-agenda-time-grid)))))
          ad-do-it))
    ad-do-it))
(ad-activate 'org-agenda-add-time-grid-maybe)

- Michael

-- 
mouse, n: A device for pointing at the xterm in which you want to type.
Confused by the strange files?  I cryptographically sign my messages.
For more information see <http://www.elehack.net/resources/gpg>.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode