From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Re: [PATCH] little fixes for attachment git commiting Date: Thu, 18 Feb 2010 21:11:42 +0100 Message-ID: <87ocjmmhhd.wl%maus.david@gmail.com> References: <87635xuhnd.fsf@dasa3.iem.pw.edu.pl> <871vglrkr4.wl%maus.david@gmail.com> <87y6isj27f.fsf@dasa3.iem.pw.edu.pl> <874olg2sqf.wl%maus.david@gmail.com> <87hbpg15kz.fsf@dasa3.iem.pw.edu.pl> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============0086712810==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiCj0-000776-Rr for emacs-orgmode@gnu.org; Thu, 18 Feb 2010 15:11:50 -0500 Received: from [140.186.70.92] (port=39710 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiCiz-00075M-0H for emacs-orgmode@gnu.org; Thu, 18 Feb 2010 15:11:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiCix-0003B1-P9 for emacs-orgmode@gnu.org; Thu, 18 Feb 2010 15:11:48 -0500 Received: from fg-out-1718.google.com ([72.14.220.153]:4077) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiCix-0003As-Kh for emacs-orgmode@gnu.org; Thu, 18 Feb 2010 15:11:47 -0500 Received: by fg-out-1718.google.com with SMTP id 16so71336fgg.12 for ; Thu, 18 Feb 2010 12:11:46 -0800 (PST) In-Reply-To: <87hbpg15kz.fsf@dasa3.iem.pw.edu.pl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?UTF-8?B?xYF1a2Fzeg==?= Stelmach Cc: emacs-orgmode@gnu.org --===============0086712810== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Thu_Feb_18_21:11:38_2010-1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Thu_Feb_18_21:11:38_2010-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =C5=81ukasz Stelmach wrote: >David Maus writes: >> =C5=81ukasz Stelmach wrote: >>>David Maus writes: >> >>>> =C5=81ukasz Stelmach wrote: >>>>>The other one helps if for some reason the file one would like to add >>>>>matches an entry in a .gitignore file. I suppose no one puts anything = in >>>>>the org-attach-directory by hand, so anything that goes there is by >>>>>intention. >>>>>http://github.com/steelman/steelman-org-mode/commit/8ade081fd5a331cc61= f8f8a6f8cf5a92ff8881d5 >>>> >[...] >>>> In addition one might explicitly include the content of attachment >>>> directories using the negating operator in .gitignore. >>>This might be a better solution indeed. >> >> Yep. Though about it: Using the -f switch overrides any configuration >> of git a user may have made in a system wide, user or repository >> specific gitignore -- that shouldn't be turned on by default or even >> enforced in the source. >You're right, I admit. Please forget this commit. Take only the one >about xargs --no-run-if-empty >http://github.com/steelman/steelman-org-mode/commit/8dc5033d13af1d0aa6f109= 4a1775cc1a1ec33c67 Looks good to me. It handles the case when "git ls-files --deleted -z" returns an empty string (nothing to delete) that is currently handled by rm silently issuing an error message. Regards -- David --=20 OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... maus.david@gmail.com --pgp-sign-Multipart_Thu_Feb_18_21:11:38_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkt9nv4ACgkQma24O1pEeObUoAEAj4JTvltbD5UM95wHFRs0FBvD /Bt2Co6pMrdYpjWNxvUBALU+VfKH0SWRXCtcmfQQyyxuDyc6rNQEqnwHwDWozRVo =xGg9 -----END PGP SIGNATURE----- --pgp-sign-Multipart_Thu_Feb_18_21:11:38_2010-1-- --===============0086712810== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0086712810==--