From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Rose Subject: Re: Re: Testing --- again... Date: Sun, 03 Oct 2010 02:46:43 +0200 Message-ID: <87ocbbvuig.fsf@gmx.de> References: <87vd5li75s.fsf@gmx.de> <0CDCC1C3-3D93-465E-827C-A722978F4D13@gmail.com> <87fwwoihuy.fsf@gmail.com> <87fwwobd9k.fsf@gmx.de> <871v88ibhh.fsf@gmail.com> <87sk0ofef3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=39996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2W3s-0004bp-T8 for emacs-orgmode@gnu.org; Sun, 03 Oct 2010 17:25:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P2W3r-0000UE-LS for emacs-orgmode@gnu.org; Sun, 03 Oct 2010 17:25:36 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:48189 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P2W3r-0000Tp-4D for emacs-orgmode@gnu.org; Sun, 03 Oct 2010 17:25:35 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Emacs-orgmode mailing list , Carsten Dominik "Eric Schulte" writes: > "Eric Schulte" writes: > To illustrate my suggestions, I've thrown together a couple simple Babel > tests roughly following this outline, currently up in the > `schulte-testing' branch of the Org-mode repo. > > To try it out > 1) load the testing/org-test.el file > 2) run `org-load-tests' to load up the entire org-mode test suite > 3) run `ert' to run the test suite. > 4) or jump to the definition of `org-babel-get-src-block-info' and run > `org-test-current-function' to just run the tests for that function > > Best -- Eric Yes. I know how running tests looks like: It looks good :) Hahaa, I like that code. It looks so simple :) To load all files below testing/ is a good suggestion probably. The unloading and loading as I implemented it is simply superfluous, if we suggest that testers no how to eval a buffer or defun (and if they can change it, they can eval it). * Question: (defun org-test-current-function () "Test the current function." (interactive) (ert (car (which-function)))) `org-test-test-current-defun' in the ert-testing branch does that, too. (But with that superfluous loading/unloading stuff though :-/) But it encloses each test inside save-excursion and Co. What does which-func.el that this function does not: <#part type="application/emacs-lisp" disposition=inline> (defun org-test-which-func () "Return the name of the current defun." (save-excursion (save-match-data (end-of-line) (beginning-of-defun) (if (looking-at "(defun[[:space:]]+\\([^([:space:]]*\\)[[:space:]]*(") (match-string-no-properties 1) (error "No defun found around point."))))) <#/part> ?? * Keymap We should add keys to the org-mode-map. C-c t is still free here. Or is it in you use it for babel somehow? C-c t f org-test-test-current-function C-c t b org-test-test-current-buffer-file * ERT Selectors I see a little namespace problem coming up. Imagine testing org.el. Which ert selector would we use? "^org" ??? :-/ Should we create hashes of filenames as selectors (just kidding)? Or use the entire filename "^org.el"? The relative path "^lisp/org.el"? * About the directory structure: It does not burden the user, as tests are loaded and executed automatically (per function, per file or all, depending on the command used). But imagine the entire thing grows and someone would add tests for all the stuff in emacs/lisp/. Or add tests files for single functions simply because there is so much to test that one file would be hard to handle. This could cause a lot of clutter. Is this too hypothetical? Hmmm - it might be... If you checkout ert-testing, eval testing/org-test.el and do M-x org-test-edit-buffer-file-tests you're in your test file in the correct directory (which is created if it doesn't exist). M-x org-test-edit-current-defuns-tests creates a file named after the defun you're in. You'll need to be in an elisp file of course. The testing/ directory will resemble the directory structure of the project. Every one who saw that directory structure simply asked "don't you think it's overkill?" :D I'll probably drop that. We could go on on two rails for a while. I'll need this week to dig deeper into ERT and come to conclusions. It would be a good thing if we could agree about the keys and the selectors (again: "^org"), so that it's painless to switch branches ;) Sebastian