emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Łukasz Stelmach" <lukasz.stelmach@iem.pw.edu.pl>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] quote the real csv separator
Date: Mon, 25 Oct 2010 13:59:44 +0200	[thread overview]
Message-ID: <87ocaimqj3.fsf@dasa3.iem.pw.edu.pl> (raw)
In-Reply-To: 627E784E-E564-4604-A644-1D7CBC1597F8@gmail.com

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Oct 25, 2010, at 10:45 AM, Łukasz Stelmach wrote:
>> OR, if you think that CSV should stay as it is then I
>> suggest such a rewrite:
>>
>> (defun orgtbl-to-csv (table params)
>>  (orgtbl-to-generic table (org-combine-plists
>>                            params
>> 			    '(:sep "," :fmt org-quote-csv-field))))
>>
>> to make CSV :sep and and :fmt mandatory (that's how this all have
>> starded).
>
> I don't understand, here is the current definition of orgtbl-to-csv:
>
> (defun orgtbl-to-csv (table params)
>   "Convert the orgtbl-mode table to CSV material.
> This does take care of the proper quoting of fields with comma or
> quotes."
>   (orgtbl-to-generic table (org-combine-plists
> 			    '(:sep "," :fmt org-quote-csv-field)
> 			    params)))
>
> so these are mandatory.  I guess I do not understand what you are
> saying.

OK, try to eval these:

(let ((params '(:sep "|")))
  (org-combine-plists
    '(:sep "," :fmt org-quote-csv-field)
    params))

(let ((params '(:sep "|")))
  (org-combine-plists
    params
    '(:sep "," :fmt org-quote-csv-field)))

The latter prevents :sep from being overriden.

-- 
Miłego dnia,
Łukasz Stelmach

  reply	other threads:[~2010-10-25 12:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-23 22:56 [PATCH] quote the real csv separator Łukasz Stelmach
2010-10-24 16:26 ` Carsten Dominik
2010-10-24 16:52   ` Nick Dokos
2010-10-24 19:37     ` Carsten Dominik
2010-10-25 10:32     ` Stefan Vollmar
2010-10-24 20:49   ` Łukasz Stelmach
2010-10-25  1:25     ` Bernt Hansen
2010-10-25  8:45       ` Łukasz Stelmach
2010-10-25  9:06         ` Carsten Dominik
2010-10-25 11:59           ` Łukasz Stelmach [this message]
2010-10-25  9:15   ` Sébastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocaimqj3.fsf@dasa3.iem.pw.edu.pl \
    --to=lukasz.stelmach@iem.pw.edu.pl \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).