From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: ob-sql error because of not specifying column-seperator Date: Fri, 03 Dec 2010 06:59:38 -0700 Message-ID: <87oc932adx.fsf@gmail.com> References: <20101203.140155.105952638.joost@snow.nl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=49299 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POWiQ-0000Y7-Ts for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 09:34:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POWiO-0001fc-EA for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 09:34:26 -0500 Received: from mail-gx0-f169.google.com ([209.85.161.169]:52187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POWiO-0001fV-8j for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 09:34:24 -0500 Received: by gxk5 with SMTP id 5so5449142gxk.0 for ; Fri, 03 Dec 2010 06:34:23 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Joost Helberg Cc: emacs-orgmode@gnu.org Applied, Thanks for the patch -- Eric Joost Helberg writes: > Hi, > > when using babel SQL, the column's in the resultset are converted to > org-tables using (org-table-import file sep). > > The command used to retrieve the information from the databaseserver > gets the option to use the tab (\t) as columnseperator. > > The call to org-table-import however doesn't specify this > seperator. This leaves it to org-table-import to find out what the > seperator is. org-table-import doesn't always succeed in this. Hence > the diff below which sets the seperator to (\t). > > regards, > > Joost Helberg > > diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el > index 19c271d..6bb9a96 100644 > --- a/lisp/ob-sql.el > +++ b/lisp/ob-sql.el > @@ -80,7 +80,7 @@ This function is called by `org-babel-execute-src-block'." > (message command) > (shell-command command) > (with-temp-buffer > - (org-table-import out-file nil) > + (org-table-import out-file '(16)) > (org-babel-reassemble-table > (org-table-to-lisp) > (org-babel-pick-name (cdr (assoc :colname-names params))