From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hrvoje Niksic Subject: Re: [PATCH] Markup on same line as text Date: Sun, 20 Feb 2011 00:49:14 +0100 Message-ID: <87oc674mbp.fsf@xemacs.org> References: <4D263E3B.5030407@gmail.com> <87ipwijpci.fsf@xemacs.org> <4D5FD32E.5000204@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=53346 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqwYJ-00089d-At for emacs-orgmode@gnu.org; Sat, 19 Feb 2011 18:49:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqwYI-0001UC-0j for emacs-orgmode@gnu.org; Sat, 19 Feb 2011 18:49:27 -0500 Received: from smtp.xnet.hr ([83.139.103.71]:50333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqwYH-0001QQ-MU for emacs-orgmode@gnu.org; Sat, 19 Feb 2011 18:49:25 -0500 Received: from mail.globalnet.hr (cartman.bnet.hr [213.149.32.10]) by smtp.xnet.hr (XnetMailOut) with ESMTP id BD09E47FF1 for ; Sun, 20 Feb 2011 00:49:16 +0100 (CET) In-Reply-To: <4D5FD32E.5000204@gmail.com> (Roland Kaufmann's message of "Sat, 19 Feb 2011 15:26:54 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Roland Kaufmann Cc: emacs-orgmode@gnu.org Roland Kaufmann writes: >> htmlize doesn't operate on the level of syntax-based fontification, it >> examines the display-related properties attached to buffer text (not >> necessarily by font-lock) and renders them into the corresponding HTML. > > Good point. > > And, as you point out, it is probably better to deal with the problem > by removing the formatting on the newlines (probably right after > font-lock-fontify-buffer in org-export-format-source-code-or-example) > in the temporary buffer that is htmlize'd, reducing the chance of any > unintended consequences. Yes, tweaking the properties seems preferable to tweaking htmlize itself for this particular case. In the future I'd like htmlize to be more extensible about converting buffer contents to HTML. Currently it only examines the `face' and `invisible' properties that Emacs itself uses for display. But additional properties could be defined, which htmlize would use to discern hyperlinks, or to add line highlight markup, to override choice of style sheet, etc. > I'll try this approach and see how it turns out (i.e. proposal for > change in htmlize dropped). Thank you for the feedback! Thanks for sticking with this. Please let me know how it works for you.