emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <schulte.eric@gmail.com>
To: Julien Barnier <julien@nozav.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix some #+ blocks fontification when there is no	lang attribute
Date: Fri, 01 Jul 2011 17:38:16 -0700	[thread overview]
Message-ID: <87oc1decuf.fsf@gmail.com> (raw)
In-Reply-To: <loom.20110702T020009-500@post.gmane.org> (Julien Barnier's message of "Sat, 2 Jul 2011 00:03:22 +0000 (UTC)")

Julien Barnier <julien@nozav.org> writes:

> Hi Bastien,
> Bastien <bzg <at> altern.org> writes:
>> > * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
>> > lang attribute
>> >
>> > When there is no lang attribute to a block (for quote, verse or others), the
>> > lang variable is not nil, but an empty string.
>> Applied, thanks!
> Maybe I'm mistaken, but I think there is a problem with the patch : in the patch
> file I sent the new line was the following :
> ((and lang (not (string= lang "")) org-src-fontify-natively)
> But it seems that the applied patch in the git repository is the following :
> ((and lang (not (string= lang "") org-src-fontify-natively))
> http://repo.or.cz/w/org-mode.git/commitdiff/549a5212566e300023e038ec945cb9e8efe37e19
> As you can see, the parenthesis is not at the right place, and this seems to
> break completely src code blocks fontification...
> Thanks in advance,

Fixed.  Thanks for reporting -- Eric

Eric Schulte

  reply	other threads:[~2011-07-02  0:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 14:46 [PATCH] Fix some #+ blocks fontification when there is no lang attribute julien Barnier
2011-07-01 15:29 ` Bastien
2011-07-02  0:03   ` Julien Barnier
2011-07-02  0:38     ` Eric Schulte [this message]
2011-07-02  9:07       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oc1decuf.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=julien@nozav.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).