emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [bug] Can't find remote table when name is downcased
Date: Mon, 02 Apr 2012 17:49:01 +0200	[thread overview]
Message-ID: <87obraw2vm.fsf@gnu.org> (raw)
In-Reply-To: <808viegn8a.fsf@somewhere.org> (Sebastien Vauban's message of "Mon, 02 Apr 2012 17:36:05 +0200")

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi Sébastien,

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Bastien wrote:
>> "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
>>
>>> The error
>>>
>>>     if: Can't find remote table "onsite"
>>>
>>> is reported if the table name is in downcase (as in the following
>>> example).
>>
>> Can you try this patch and report?
>
> 1. Applied the patch manually.
> 2. Restarted Emacs (to be sure, as it is a defconst).
> 3. Tested.
>
>    But, no, it does not work on the provided example: remote table is still
>    not found.

Please test this new patch.

I won't apply this before we sort out the conventions around using
downcase/uppercase keywords, as Ilya stated a while ago.

Thanks,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-tbl-line-downcase2.patch --]
[-- Type: text/x-patch, Size: 963 bytes --]

diff --git a/lisp/ob.el b/lisp/ob.el
index 726245c..49ce76a 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -439,3 +439,3 @@ specific header arguments as well.")
 
-(defvar org-babel-data-names '("TBLNAME" "RESULTS" "NAME"))
+(defvar org-babel-data-names '("tblname" "results" "name"))
 
diff --git a/lisp/org-table.el b/lisp/org-table.el
index ae12cee..4bf025b 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3828,3 +3828,3 @@ Use COMMAND to do the motion, repeat if necessary to end up in a data line."
 (defconst orgtbl-line-start-regexp
-  "[ \t]*\\(|\\|#\\+\\(TBLFM\\|ORGTBL\\|TBLNAME\\):\\)"
+  "[ \t]*\\(|\\|#\\+\\(tblfm\\|orgtbl\\|tblname\\):\\)"
   "Matches a line belonging to an orgtbl.")
@@ -4734,3 +4734,3 @@ list of the fields in the rectangle ."
 	    (if (re-search-forward
-		 (concat "^[ \t]*#\\+TBLNAME:[ \t]*" (regexp-quote name-or-id) "[ \t]*$")
+		 (concat "^[ \t]*#\\+tblname:[ \t]*" (regexp-quote name-or-id) "[ \t]*$")
 		 nil t)


[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

  reply	other threads:[~2012-04-02 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 13:54 Sebastien Vauban
2012-04-02 15:05 ` Bastien
2012-04-02 15:36   ` Sebastien Vauban
2012-04-02 15:49     ` Bastien [this message]
2012-04-02 21:01       ` Sebastien Vauban
2012-04-03 12:41         ` Sebastien Vauban
2012-04-21 13:40           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obraw2vm.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    --subject='Re: [bug] Can'\''t find remote table when name is downcased' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).