emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Bob Newell <bobnewell@bobnewell.net>,
	Thorsten Jolitz <tjolitz@googlemail.com>,
	Nick Dokos <nicholas.dokos@hp.com>,
	Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Distinguish between blank and zero in org-mode spreadsheet
Date: Sat, 29 Dec 2012 14:39:07 +0100	[thread overview]
Message-ID: <87obhdf05g.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CALn3zois8R3YL3B6dA8n25kj_HvFnqrrRxGRRaTTrrK4C8=V5w@mail.gmail.com> (Michael Brand's message of "Fri, 28 Dec 2012 15:10:22 +0100")

Hi Michael,

this is just great!  Thanks a lot for this major enhancement,
and for your details explanations and tests.

Michael Brand <michael.ch.brand@gmail.com> writes:

> Patch 6 of the attached patches makes it possible to write
> spreadsheet Calc formulas that check for empty fields: To sum the
> first two columns unless one or both empty:
> $3 = if("$1" = "nan" || "$2" = "nan", string(""), $1 + $2); E
>
> The other patches:
>
> - patch 1: testing/README: add howto run ERT partially

Nice.

> - patch 2: Add ERT for table alignment within Org buffer
>
>   The new function org-test-table-target-expect is to simplify writing
>   spreadsheet ERT by providing just a target table to apply the formula
>   to, the expected result table and the table formula with optionally
>   additional variants. The variants typically are to check the same
>   result with a Lisp formula and a Calc formula. test-org-table.el is
>   also a howto example collection as a user documentation.
>
> - patch 3: Extend org-table-number-regexp
>
> - patch 4: Add ERTs for basic spreadsheet functionality
>
>   My plan is to add spreadsheet examples only to Org ERT
>   (test-org-table.el) from now on and someday to move those I already
>   made on Worg.
>
> - patch 5: org-table.el: Fix range len bugs and inconsistencies
>
>   The range len bugs may lead to wrong calculations for range references
>   with empty fields when the range len is relevant.  Affects typically
>   Calc vmean on simple range and without format specifier EN.  Also
>   Lisp with e. g. `length' on simple range or with L.
>
> Note: Org ERT passes after every single patch to document the behavior
> of each patch.
>
> After the review is complete please make sure that “make check” passes
> before applying the patches and also before git push. I hope I got it
> right with the require to resolve the dependencies.

make         => fine
make single  => fine
make test    => all 339 tests passed 

I pushed the 6 commits to master.  

Thanks,

-- 
 Bastien

     prev parent reply	other threads:[~2012-12-29 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 22:32 Distinguish between blank and zero in org-mode spreadsheet Bob Newell
2012-12-10 22:57 ` Thorsten Jolitz
2012-12-11  4:50   ` Bob Newell
2012-12-11  6:10     ` Nick Dokos
2012-12-11 15:14       ` Michael Brand
2012-12-15  9:15         ` Michael Brand
2012-12-15  9:23           ` Bastien
2012-12-28 14:10             ` Michael Brand
2012-12-29 13:39               ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obhdf05g.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=bobnewell@bobnewell.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael.ch.brand@gmail.com \
    --cc=nicholas.dokos@hp.com \
    --cc=tjolitz@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).