From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results Date: Fri, 08 Mar 2013 22:53:33 +0100 Message-ID: <87obetsgma.fsf@Rainer.invalid> References: <1362542863-25992-1-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:44568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE5Eh-0000Ut-78 for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:54:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE5Eb-00036O-Uu for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:53:55 -0500 Received: from plane.gmane.org ([80.91.229.3]:54651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE5Eb-00036K-ON for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:53:49 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UE5Ev-00007z-8g for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 22:54:09 +0100 Received: from pd9eb526f.dip.t-dialin.net ([217.235.82.111]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 08 Mar 2013 22:54:09 +0100 Received: from Stromeko by pd9eb526f.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 08 Mar 2013 22:54:09 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > In order for the cache feature to work, the hash of a finished > computation must be inserted. But, this is not currently done for src > blocks which have the option :results none. Thus, we should insert a > dummy empty result for these blocks, which will hold the hash. Getting a results block when specifying ":results none" feels a bit strange. Since it is not the results that are hashed, but the effective parameters of the invocation, wouldn't it make more sense to store the parameter hash with the source block or call rather than the result? That would free up the current place to hash the actual result to check if the results have been tampered with. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada