From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance Date: Mon, 17 Mar 2014 20:08:08 +0100 Message-ID: <87ob14d4o7.fsf@bzg.ath.cx> References: <87bnx9qbcq.fsf@bzg.ath.cx> <87vbvcptqt.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPctj-00056S-0i for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPctd-0002oA-TM for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:08:30 -0400 Received: from rs249.mailgun.us ([209.61.151.249]:37078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPctd-0002o2-Om for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:08:25 -0400 In-Reply-To: <87vbvcptqt.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 17 Mar 2014 19:25:46 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Bastien writes: >> Applied, thanks! > > That badly breaks the following tests: > > FAILED test-ob-header-arg-defaults/tree/accumulate/call > FAILED test-ob-header-arg-defaults/tree/accumulate/noweb > FAILED test-ob-header-arg-defaults/tree/complex/call > FAILED test-ob-header-arg-defaults/tree/complex/noweb > FAILED test-org-property-accumulation-append-use > FAILED test-org-property-accumulation-append-val Can you tell a bit more about what's wrong with the test? If the patch is good and the tests are outdated, I'd rather fix the tests than revert the patch to re-revert it again. Thanks, -- Bastien