From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fix: allow org-refile in goto mode from everywhere Date: Sun, 20 Apr 2014 08:04:47 +0200 Message-ID: <87oazwsfi8.fsf@bzg.ath.cx> References: <878urhgh9y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbksC-00085n-95 for emacs-orgmode@gnu.org; Sun, 20 Apr 2014 02:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wbks0-0007JU-U9 for emacs-orgmode@gnu.org; Sun, 20 Apr 2014 02:05:04 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:44559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wbks0-0007JD-NI for emacs-orgmode@gnu.org; Sun, 20 Apr 2014 02:04:52 -0400 Received: by mail-we0-f172.google.com with SMTP id t61so2814901wes.17 for ; Sat, 19 Apr 2014 23:04:51 -0700 (PDT) In-Reply-To: <878urhgh9y.fsf@gmail.com> (Markus Hauck's message of "Mon, 07 Apr 2014 19:51:05 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Markus Hauck Cc: emacs-orgmode@gnu.org Hi Markus, Markus Hauck writes: > It seems like org-refile with the goto argument is no longer allowed > From non org-mode buffers. I reverted your patch. > In commit 49da67d the condition was changed from: > > (unless goto ...) > > to: > > (unless (and goto (listp goto)) ...) > > where the condition of unless is only true for non-empty lists. That's in fact on purpose. If you want to use org-refile to go to a location, use (org-refile '(4)), the '(4) emulates the universal prefix argument. Note that With your patch, the prompt for org-refile (as (org-refile nil)) was asking "Goto: " because (listp nil) is `t'. Let me know if I missed something. -- Bastien