From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: Enabling another language in org-babel
Date: Tue, 29 Jul 2014 16:36:06 +0200
Message-ID: <87oaw8b5bd.fsf@bzg.ath.cx>
References: <87ionqhelv.fsf@wivenhoe.ul.ie>
	<87lhsmefj9.fsf@gmail.com>	<m261jqldg8.fsf@krugs.de>	<CA+vqiLH_hcEraZAtjKiZSSSe_mFDuTmHV=uh88XRgQnAa51fqg@mail.gmail.com>	<87vbrpl76d.fsf@bzg.ath.cx>	<CA+vqiLGx7aE5ZnRz2-5wCnso0vKFYnNXOSxTDos8LD16uCd_Bw@mail.gmail.com>	<878und1jm8.fsf@bzg.ath.cx>	<CA+vqiLGxOxYVdF7VNaYNVebdDWXTSMf6vJPLnZsixKm9Zq=Xfw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1XC8Vp-0002pT-VE
	for emacs-orgmode@gnu.org; Tue, 29 Jul 2014 10:36:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1XC8Vj-0007OD-7s
	for emacs-orgmode@gnu.org; Tue, 29 Jul 2014 10:36:21 -0400
Received: from mail-s76.mailgun.info ([184.173.153.204]:35052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1XC8Vj-0007O9-49
	for emacs-orgmode@gnu.org; Tue, 29 Jul 2014 10:36:15 -0400
In-Reply-To: <CA+vqiLGxOxYVdF7VNaYNVebdDWXTSMf6vJPLnZsixKm9Zq=Xfw@mail.gmail.com>	(Ista
	Zahn's message of "Mon, 28 Jul 2014 17:29:00 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Ista Zahn <istazahn@gmail.com>
Cc: "G. Jay Kerns" <gjkerns@gmail.com>, emacs-orgmode <emacs-orgmode@gnu.org>, brendan.halpin@ul.ie, Eric Schulte <schulte.eric@gmail.com>

Hi Ista,

some comments on the code below.

Ista Zahn <istazahn@gmail.com> writes:

> ;; Copyright (C) 2014 Ista Zahn
> ;; Author: Ista Zahn, based on ob-julia.el by G. Jay Kerns, and ob-R.el
> ;; by Eric Schulte and Dan Davison

You need to reformat this -- see files with multiple authors in Org or
in Emacs.

> ;; This file is not part of GNU Emacs.

We plan to add this to Org's core, so this will be part of Emacs.

> ;; Stata and ESS are required.

Maybe add some links for the requirements.

> (defcustom org-babel-stata-command inferior-STA-program-name
>   "Name of command to use for executing stata code."
>   :group 'org-babel
>   :version "24.4"
>   :package-version '(Org . "8.0")
                              ^^^

This needs to be 8.3

> ;; The following was a very complicated write object command
> ;; The replacement needs to add error catching
> ;(defvar org-babel-stata-write-object-command "{function(object,transfer.file){object;invisible(if(inherits(try({tfile<-tempfile();write.table(object,file=tfile,sep=\"\\t\",na=\"nil\",row.names=%s,col.names=%s,quote=FALSE);file.rename(tfile,transfer.file)},silent=TRUE),\"try-error\")){if(!file.exists(transfer.file))file.create(transfer.file)})}}(object=%s,transfer.file=\"%s\")")

Maybe simply remove this, or make it more readable.

Thanks in advance for this contribution!

-- 
 Bastien