From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption for minted listings Date: Sat, 23 Aug 2014 16:27:07 -0400 Message-ID: <87oavbostg.fsf@gmail.com> References: <1408779394-11436-1-git-send-email-aaronecay@gmail.com> <87ha13dm3v.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLHuA-0003da-Pm for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 16:27:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLHu1-0003kF-Od for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 16:27:18 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:43823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLHu1-0003kB-Jy for emacs-orgmode@gnu.org; Sat, 23 Aug 2014 16:27:09 -0400 Received: by mail-qg0-f49.google.com with SMTP id j107so11554944qga.22 for ; Sat, 23 Aug 2014 13:27:09 -0700 (PDT) In-Reply-To: <87ha13dm3v.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Hi Nicolas, 2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen: >=20 > Hello, >=20 > Aaron Ecay writes: >=20 >> * lisp/ox-latex.el (org-latex-src-block): Support :float no with >> caption for minted. >> (org-latex-listings): Edit docstring to describe this usecase. >=20 > There is already :float nil, which is documented in the manual. You=E2=80=99re right =E2=80=93 this was confusion on my part induced by bab= el header args, which use yes and no instead of t and nil. I=E2=80=99ll fix it. >=20 >> + (cond ((and (string=3D "no" float) caption) >> + (format "%%s\n%s" (replace-regexp-in-string >> + "\\\\caption" "\\captionof{listing}" >> + caption-str t t))) >=20 > I think this should be a (trivial) filter. Is there any reason to > support "captionof" package out of the box? It=E2=80=99s not adding any new functionality to the exporter, but rather covering one particular combination of already-existing options (caption provided, :float nil, org-latex-listings =3D minted) that does not produce sensible output presently. Should I fix the nil/no issue and send a new patch? Thanks for your feedback, --=20 Aaron Ecay