From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATH] Speedups to org-table-recalculate
Date: Sat, 22 Nov 2014 00:30:31 +0100
Message-ID: <87oas03ze0.fsf@nicolasgoaziou.fr>
References: <CAPrg3HAnBUysnoeRWWU61uN5eEjp4B-mrOE5TCfNBisTi5+tbA@mail.gmail.com>
	<CAPrg3HD5SxVZJWc4ho1XyhyqeVJsk3M5Pgpvbnucvmfz8tzj3Q@mail.gmail.com>
	<CALn3zojr8w7Q3Q2dUEn0PWuBUpU-xCtsxWdAOkq7nc9oYmCY9g@mail.gmail.com>
	<CAPrg3HB7nYtgZ4OrwerokE3mtk6rkPtRAyPPPdUxfGwwM-ekLA@mail.gmail.com>
	<CALn3zogUBcy3VZPLb7zc3N9j8ibECi41Wbar6Hw_7xiOUvA5VA@mail.gmail.com>
	<CAPrg3HALf6UDzpFvoqEV2u1Z7vHqV4r7m5v0KxyTod05m_Rf7A@mail.gmail.com>
	<CALn3zoiqUfGR6G24YDqH69ZOdiAHX72yqJ+6Xdq+ELmv2n0qmg@mail.gmail.com>
	<CAPrg3HDSAH_n4GhSQpCrv19hjqCVA3TM5VJgdj1Jhzwa+JQNyA@mail.gmail.com>
	<CALn3zogsgiN9KkgkgGKH6wy6sO0g6U+MMAht252rviBDNh0YwQ@mail.gmail.com>
	<CAPrg3HCEd7VJyyo1z9860cHuqReQLsWrEWHgq7erLiEc4oTYxg@mail.gmail.com>
	<CALn3zojScmbeU8ON6r-wyYXJJNbfuj2BbvN=co9FSxHqnoqihA@mail.gmail.com>
	<CAPrg3HDm-cz=pDz21A=Cf9OnWGV07J7CSx3NzuVd=W+MeAYE3w@mail.gmail.com>
	<CALn3zoi9E5C78NOzNxAXBRi7vU8jJkSOHeYLUM_9CMABSSrRSg@mail.gmail.com>
	<CAPrg3HDKL+oJu-6XZijhUqasWa434N8U6AGFzcUVY6-+ukpU+w@mail.gmail.com>
	<CALn3zoi9aTqLN01vXSzgPAq_diSwLEHcvfTtv7CaYxLe44VVcA@mail.gmail.com>
	<CAPrg3HA0Kv-VigNdY=PnhkWEmNbGcPC3K-T1-vj3B=pgh+43ZQ@mail.gmail.com>
	<CALn3zoj3ZNSZvPob7gkT3SB_ORhN6pC51nOv-k5yXkuaU=Ennw@mail.gmail.com>
	<CAPrg3HDkyRZPo1J4OMD11r-KvJ_e7-ZXdBh0Jc4Uq1iH38s29A@mail.gmail.com>
	<CALn3zogNTthgi0xHf3ijjEENBMKiLZuOFfp_06a=7ap34GfLyA@mail.gmail.com>
	<87oas9tnlm.fsf@selenimh.mobile.lan>
	<CAPrg3HDmcfWbdWrfSg6ZWHfDnBpCjW21xqcHNp_0o4eZMZnm1A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XrxeA-0000Zl-3u
	for emacs-orgmode@gnu.org; Fri, 21 Nov 2014 18:30:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Xrxdz-0008DJ-Ud
	for emacs-orgmode@gnu.org; Fri, 21 Nov 2014 18:29:50 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:40460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Xrxdz-0008D5-Ot
	for emacs-orgmode@gnu.org; Fri, 21 Nov 2014 18:29:39 -0500
In-Reply-To: <CAPrg3HDmcfWbdWrfSg6ZWHfDnBpCjW21xqcHNp_0o4eZMZnm1A@mail.gmail.com>
	(Nathaniel Flath's message of "Fri, 21 Nov 2014 14:40:32 +0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nathaniel Flath <flat0103@gmail.com>
Cc: Michael Brand <michael.ch.brand@gmail.com>, org-mode List <emacs-orgmode@gnu.org>

Nathaniel Flath <flat0103@gmail.com> writes:

> OK, I think I fixed that.

Thanks.

I didn't verify it compiles, but your macro still looks suspicious.

> +(defmacro org-table-execute-once-per-second (t1 &rest body)
> +  "If there has been more than one second since T1, execute BODY.
> +Updates T1 to 'current-time' if this condition is met. If T1 is
> +nil, always execute body."
> +  `(let ((t1 ,t1))
> +     (if t1
> +	 (let ((curtime (current-time)))
> +	   (when (< 0 (nth 1 (time-subtract curtime t1)))
> +	     (setq t1 curtime)
> +	   ,@body))
> +       ,@body)))

You shouldn't splice BODY twice in your macro. Also, I don't get why you
need to (setq t1 curtime).

Do you need a macro at all for this task? ISTM you only need to display
a message conditionally and update a time value.


Regard,