From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape
 for ob-ruby
Date: Wed, 12 Aug 2015 13:21:41 -0400
Message-ID: <87oaic4e3e.fsf@kyleam.com>
References: <CA+GZiYozqNe7T+A3_n0x=bEV3bPBcGn2zpmwxK5Zc2EDS6jnHQ@mail.gmail.com>
	<87h9o5316t.fsf@kyleam.com> <87bned311f.fsf@kyleam.com>
	<CA+GZiYp19iQ1giRpc=3XjN_eXh_NGXn2XSi6JHWzia=oLvAJYw@mail.gmail.com>
	<874mk5coqy.fsf@kmlap.domain.org>
	<CA+GZiYpLamH4eXjRGUpgOspPdbjAJhUjuapnU6njgWKi8hgmsQ@mail.gmail.com>
	<87fv3pxdar.fsf@kmlap.domain.org>
	<CA+GZiYrWfYBriyb3c_UbBj89cTYUaHnJ23K0A9=mT+TebJmTGg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPZji-0001Id-NY
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 13:22:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPZje-00037a-In
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 13:22:46 -0400
Received: from mail-qk0-f179.google.com ([209.85.220.179]:32955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZPZje-00037W-F3
	for emacs-orgmode@gnu.org; Wed, 12 Aug 2015 13:22:42 -0400
Received: by qkfj126 with SMTP id j126so7450071qkf.0
	for <emacs-orgmode@gnu.org>; Wed, 12 Aug 2015 10:22:42 -0700 (PDT)
In-Reply-To: <CA+GZiYrWfYBriyb3c_UbBj89cTYUaHnJ23K0A9=mT+TebJmTGg@mail.gmail.com>
	(Matthew MacLean's message of "Wed, 12 Aug 2015 00:18:13 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matthew MacLean <archenoth@gmail.com>
Cc: emacs-orgmode@gnu.org

Matthew MacLean <archenoth@gmail.com> writes:

> Alright, done. Is this acceptable? (Provided that tests don't count towards
> line count, of course)

Thanks.  A few minor comments on the commit message.

> Subject: [PATCH] ob-ruby: Fix double-escaping
>
> * lisp/ob-ruby.el: Remove second call to
>   `org-babel-ruby-table-or-string' in `org-babel-ruby-evaluate'.

Please add the name of the changed function in parentheses after the
file name rather than putting it in the description body.

> * testing/lisp/test-ob-ruby.el: Add test to verify
>   `org-babel-execute:ruby' can evaluate Ruby code. (What the
>   double-escape prevented)

Same here for the test name.  "Add test." for description would do.

> I removed the escaping from `org-babel-ruby-evaluate', because the only
> place `org-babel-ruby-evaluate' is ever called is in
> `org-babel-execute:ruby'.
>
> In this function, its result either escaped (Where the double escape
> previously occurred) or passed in as the "scalar-form" of
> `org-babel-result-cond', which handles the "pp" and "code" parameters.
> (A place that doesn't need escaping.)

I think the above two paragraphs could be replaced by a link to this ML
post.

Thanks for working on this.

--
Kyle