From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: More clocktable breakage
Date: Sun, 14 May 2017 11:10:43 +0200 [thread overview]
Message-ID: <87o9uvztv0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87lgq9hs29.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 07 May 2017 12:36:30 +0200")
Hello,
Achim Gratz <Stromeko@nexgo.de> writes:
> Yes, put the cursor on the date or time of one of the timestamps and
> press S-Up or S-Down. It should increase or decrease the corresponding
> element of the timestamp, but instead you'll get an error message:
>
> org-clocktable-shift: Line needs a :block definition before this command works
>
> which appears because the timestamp wasn't recognized and the
> fallthrough of org-shift* then tries to apply another function that
> deals with the :block argument (which isn't present here and shouldn't
> be).
OK, reproduced.
I fixed the issue by extending `org-at-timestamp-p' optional argument
while preserving backward-compatibility.
The new docstring is:
Non-nil if point is inside a timestamp.
By default, the function only consider syntactically valid active
timestamps. However, the caller may have a broader definition
for timestamps. As a consequence, optional argument EXTENDED can
be set to the following values
`inactive'
Include also syntactically valid inactive timestamps.
`agenda'
Include timestamps allowed in Agenda, i.e., those in
properties drawers, planning lines and clock lines.
`lax'
Ignore context. The function matches any part of the
document looking like a timestamp. This includes comments,
example blocks...
For backward-compatibility with Org 9.0, every other non-nil
value is equivalent to `inactive'.
When at a timestamp, return the position of the point as a symbol
among `bracket', `after', `year', `month', `hour', `minute',
`day' or a number of character from the last know part of the
time stamp.
When matching, the match groups are the following:
group 1: year
group 2: month
group 3: day number
group 4: day name
group 5: hours, if any
group 6: minutes, if any
I also updated the callers throughout the code base.
>> I start to think that there is no bug in clock tables (but certainly in
>> the cache mechanism, probably related to some `before-change-functions'
>> and `after-change-functions' misuse there).
>
> I'm not using any of those unless they already come with Emacs or Org.
What I meant is the use of `before-change-functions' and
`after-change-functions' is wrong in the caching mechanism, not in your
configuration.
Anyway, it doesn't matter for the problem at hand.
Is your issue solved?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-05-14 9:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:24 More clocktable breakage Achim Gratz
2017-03-29 14:38 ` Nicolas Goaziou
2017-04-26 17:09 ` Achim Gratz
2017-04-27 17:56 ` Achim Gratz
2017-04-27 18:56 ` Nicolas Goaziou
2017-04-27 20:09 ` Achim Gratz
2017-04-27 22:49 ` Nicolas Goaziou
2017-04-28 18:56 ` Achim Gratz
2017-04-30 7:21 ` Nicolas Goaziou
2017-05-01 8:27 ` Achim Gratz
2017-05-02 16:47 ` Nicolas Goaziou
2017-05-02 17:32 ` Achim Gratz
2017-05-06 8:10 ` Nicolas Goaziou
2017-05-06 9:53 ` Achim Gratz
2017-05-07 10:15 ` Nicolas Goaziou
2017-05-07 10:36 ` Achim Gratz
2017-05-14 9:10 ` Nicolas Goaziou [this message]
2017-05-14 9:50 ` Achim Gratz
2017-05-15 16:28 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9uvztv0.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).