From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: Fix org.el compilation warnings
Date: Fri, 26 May 2017 16:45:53 -0400
Message-ID: <87o9ufe48u.fsf@kyleam.com>
References: <CAFyQvY38Yj-AnHVGtJW6cSobvy_=WMyL=zS8YHQaRpRXKzxGBQ@mail.gmail.com>
	<87mva0v66x.fsf@kyleam.com>
	<CAFyQvY2a7+0Tf=2WtBpaYtw_JYO=foLOKU+bumaVLofwuFzyzg@mail.gmail.com>
	<87inkouy4f.fsf@kyleam.com>
	<CAFyQvY2cXi1KyKH5SbU2UwxSh0sJVE=hQ8wMr9-wBQ1uU_ukUg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dEM7V-0005Ry-Do
	for emacs-orgmode@gnu.org; Fri, 26 May 2017 16:46:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dEM7R-00056q-81
	for emacs-orgmode@gnu.org; Fri, 26 May 2017 16:46:01 -0400
Received: from pb-smtp1.pobox.com ([64.147.108.70]:61694
	helo=sasl.smtp.pobox.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1dEM7Q-00056D-Kv
	for emacs-orgmode@gnu.org; Fri, 26 May 2017 16:45:56 -0400
In-Reply-To: <CAFyQvY2cXi1KyKH5SbU2UwxSh0sJVE=hQ8wMr9-wBQ1uU_ukUg@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>, emacs-org list <emacs-orgmode@gnu.org>

Kaushal Modi <kaushal.modi@gmail.com> writes:

>> Ah, right ... 'make compile' uses a single Emacs instance, while 'make
>> single' uses a separate Emacs instance for each file.
>
> I wasn't even doing that. I was doing M-x byte-compile-file and selecting
> org.el.

Sure, I was just noting why I didn't see the
org-agenda-include-inactive-timestamps warning when I ran 'make
compile'.  .

> That gives me (without applying your patch):
>
> Compiling file
> /home/kmodi/stow/pub_dotfiles/emacs/dot-emacs.d/elisp/org-mode/lisp/org.el
> at Fri May 26 14:04:52 2017
>
> In org-goto-map:
> org.el:7412:9:Warning: function org-goto-map used to take 0+ arguments, n=
ow
>     takes 0
>
> In org-todo:
> org.el:12398:12:Warning: function org-todo used to take 0+ arguments, now
>     takes 0-1
>
> In org-store-log-note:
> org.el:13635:8:Warning: function org-store-log-note used to take 0+
> arguments,
>     now takes 0
>
> In org-at-timestamp-p:
> org.el:17909:40:Warning: reference to free variable
>     =E2=80=98org-agenda-include-inactive-timestamps=E2=80=99
>
> In org-self-insert-command:
> org.el:19910:32:Warning: function org-self-insert-command used to take 0+
>     arguments, now takes 1
>
> So.. should we consider the warnings output by simple byte-compile-file?

When I run byte-compile-file on org.el (no Org loaded, with master's Org
first on the load-path), I don't see any of the above warnings aside
from the one for org-agenda-include-inactive-timestamps, which is fixed
by the patch.  And because running byte-compile-file from an Emacs
instance is affected by what's already been loaded, I think it's better
to focus on the output of 'make single'.

--=20
Kyle