From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Subject: Re: [PATCH 2/2] org-refile: Fix inconsistency when listing refile
 targets
Date: Wed, 21 Jun 2017 09:55:09 +0200
Message-ID: <87o9thsrky.fsf@wirrsal.net>
References: <20170515125455.18251-1-seb@wirrsal.net>
	<20170515125455.18251-2-seb@wirrsal.net>
	<CAJr1M6dvszi+xPTUG3kiM_XKFbMGpnP1rwq2beWKsnCwvZV99Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1dNaTt-0004Zm-Jz
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:55:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1dNaTp-0004fp-Np
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:55:17 -0400
Received: from wirrsal.net ([188.68.36.149]:51756 helo=mail.wirrsal.net)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <seb@wirrsal.net>) id 1dNaTp-0004eE-Dp
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:55:13 -0400
In-reply-to: <CAJr1M6dvszi+xPTUG3kiM_XKFbMGpnP1rwq2beWKsnCwvZV99Q@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello Allen,

Allen Li <vianchielfaura@gmail.com> writes:

> On Mon, May 15, 2017 at 5:54 AM, Sebastian Reu=C3=9Fe <seb@wirrsal.net>=
 wrote:
>> * org.el (org-refile-get-targets): Setting org-refile-use-outline-path
>> to `file' or `buffer-name' causes an additional target for the file=E2=
=80=99s
>> root node to be inserted. This functionality was absent when using
>> `full-file-path'. We now add this since it is convenient and makes the
>> behavior more consistent.
>> ---
>>  lisp/org.el | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 97713c523..28277e352 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -11563,6 +11563,8 @@ (defun org-refile-get-targets (&optional defau=
lt-buffer)
>>                  (push (list (file-name-nondirectory f) f nil nil) tgs=
))
>>                (when (eq org-refile-use-outline-path 'buffer-name)
>>                  (push (list (buffer-name (buffer-base-buffer)) f nil =
nil) tgs))
>> +              (when (eq org-refile-use-outline-path 'full-file-path)
>> +                (push (list (file-truename (buffer-file-name (buffer-=
base-buffer))) f nil nil) tgs))
>>                (org-with-wide-buffer
>>                 (goto-char (point-min))
>>                 (setq org-outline-path-cache nil)
>> --
>> 2.13.0
>>
>>
>
> If I'm not mistaken, the full file path needs to be wrapped in
> org-protect-slash?

Slashes that are part of file paths aren=E2=80=99t escaped anymore, as of
53bcf91a9. The only reason to escape slashes is to indicate they are not
part of the outline or file path, but part of the headline instead.

In fact it looks like Nicolas removed =E2=80=98org-protect-slash=E2=80=99=
 in 2b44a1a74
and inlined it at its only use site.

Kind regards,

Sebastian

--=20
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay