From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns Date: Sun, 15 Apr 2018 09:32:22 +0200 Message-ID: <87o9iklybd.fsf@nicolasgoaziou.fr> References: <87zi272rlu.fsf@gmail.com> <87604toikv.fsf@nicolasgoaziou.fr> <87wox9xmip.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7c9H-00050k-JQ for emacs-orgmode@gnu.org; Sun, 15 Apr 2018 03:32:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7c9G-0006fl-Nf for emacs-orgmode@gnu.org; Sun, 15 Apr 2018 03:32:31 -0400 In-Reply-To: <87wox9xmip.fsf@gmail.com> (stardiviner's message of "Sun, 15 Apr 2018 09:54:06 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: Bastien Guerry , org-mode-email Hello, stardiviner writes: > About the compilation warnings. I only did "make test". have not do > compilation test. Do you mean compile whole org-mode project or compile > a single file ob-clojure.el with [M-x byte-compile-file]? I will include > this step in my future patch workflow. make test shows compilation warnings. For extra care, you can also run "make single". > I don't know how to replace `-map` and `-contains-p` functions. Is there > any suggestions? `-map' -> `mapcar' `-contains-p' -> `member', `memq', `cl-member' or even `seq-contains', which is fine for "contrib/". > BTW, I write some documents on Worg about ob-clojure :ns usage, > ob-clojure-literate.el and ob-js :session usage etc. But I can't push to > remote. Here is my steps. I'm Cc'ing Bastien about it. Regards, -- Nicolas Goaziou