From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: links are not highlighted anymore with Org Mode 9.2
Date: Thu, 03 Jan 2019 14:45:39 +0100
Message-ID: <87o98xvoqk.fsf@nicolasgoaziou.fr>
References: <877efmj5nu.fsf@algebra20.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:53969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gf3Ju-0004DI-5A
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 08:45:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gf3Jp-0003zx-Tk
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 08:45:58 -0500
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39007)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1gf3Ji-0003wN-7i
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 08:45:49 -0500
In-Reply-To: <877efmj5nu.fsf@algebra20.de> (Daniel Borchmann's message of
	"Thu, 03 Jan 2019 13:18:29 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Daniel Borchmann <daniel@algebra20.de>
Cc: emacs-orgmode@gnu.org

Hello,

Daniel Borchmann <daniel@algebra20.de> writes:

> links in Org Mode 9.2 are not highlighted anymore if no :face keyword is
> given in =E2=80=98org-link-parameters=E2=80=99.

I cannot reproduce this.

> The reason for this seems to be that
> =E2=80=98org-activate-links=E2=80=99 uses the following code to determine=
 which face to
> use:
>
> --8<---------------cut here---------------start------------->8---
> (pcase (org-link-get-parameter type :face)
>   ((and (pred functionp) face) (funcall face path))
>   ((and (pred facep) face) face)
>   ((and (pred consp) face) face) ;anonymous
>   (_ 'org-link))
> --8<---------------cut here---------------end--------------->8---
>
> However, =E2=80=98nil=E2=80=99 is a valid face,

No, it isn't: (facep nil) =3D> nil

> and thus this form returns =E2=80=98nil=E2=80=99 instead of the default =
=E2=80=98org-link=E2=80=99
> face if no :face keyword is given.

I don't think the analysis is correct, per above.

Regards,

--=20
Nicolas Goaziou