emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [Patch] Do not ignore headers argument in ob-latex
Date: Thu, 07 May 2020 22:09:25 +0200	[thread overview]
Message-ID: <87o8qz5wy2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAC38U-ct9U2a=_-_CNmVfYVgWTeUcOnHtuLsipYCbtRNcK_n2g@mail.gmail.com> (Yuri Lensky's message of "Wed, 6 May 2020 13:04:03 -0700")

Hello,

Yuri Lensky <ydl@ydl.cm> writes:

> Subject: [PATCH] lisp/ob-latex.el: Stop ignoring headers argument

Thank you.

> During default "png" export, the "headers" argument is no longer
> explicitly ignored.

According to the TODO in that function, this is not the first time it
happens. Would you mind writing a test for it?

> +          (let ((org-format-latex-header
> +		 (concat org-format-latex-header "\n"
> +			 (string-join headers "\n"))))
> +	   (org-create-formula-image
> +            body out-file org-format-latex-options in-buffer)))

This looks hackish but I don't know how to do it otherwise. However
could you use `mapconcat' instead of `string-join'?

Also, you need to declare `org-format-latex-header' in order to silence
byte-compiler.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2020-05-07 20:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 20:04 [Patch] Do not ignore headers argument in ob-latex Yuri Lensky
2020-05-07 20:09 ` Nicolas Goaziou [this message]
2020-05-09 20:12   ` Yuri Lensky
2020-05-10 12:56     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8qz5wy2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=ydl@ydl.cm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).