From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2ENyOk6Kv15QOwAA0tVLHw (envelope-from ) for ; Sat, 16 May 2020 06:38:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uB0wNk6Kv16gewAAbx9fmQ (envelope-from ) for ; Sat, 16 May 2020 06:38:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 076A394066D for ; Sat, 16 May 2020 06:38:06 +0000 (UTC) Received: from localhost ([::1]:43928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZqSS-0007us-U9 for larch@yhetil.org; Sat, 16 May 2020 02:38:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZqRx-0007uQ-S1 for emacs-orgmode@gnu.org; Sat, 16 May 2020 02:37:33 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:54850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZqRw-0001Qt-3I for emacs-orgmode@gnu.org; Sat, 16 May 2020 02:37:33 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id BE0774A882; Sat, 16 May 2020 02:37:30 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=sasl; bh=ZoKIdclEIYBYpLvPRsy0EUg5m8Q=; b=UaNetcyWOjLQMRuJvKNK fhekJLa6+EYt1cmjCvwotMcD8PchKOqfal5ywyIx+kAGiRsBNqpBxQ2eeJjDkTY2 joG6Q6BnvaO8BXH8ukG6WezjISllEjLBl84TJWw/uahRlHD2M1nb8Tuc7llJsfji 4iqoDlsRFctUCcnG5s/IBvI= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A44B44A881; Sat, 16 May 2020 02:37:30 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version:content-type; s=mesmtp; bh=9B0P33Qs4it1mVO4qHJTbjU/IE7NDbhMc1i2W9HsCa4=; b=DsvUOjwhEX0QUg9mZmDL5ZJ2UCuUpIJJUueVN/i+PywBkgDvpNllPXwl0tij0V/D+T22iBh/eFhyhomKYgtpV8jjRC8H7GpU4AQOZw7gYilJpa3JjfTVvLN+6WCzAtmZach/8O3Ul8EJRyGoPrzAS1d6vZmMOlBWzs8/KdseBoU= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 10EDA4A880; Sat, 16 May 2020 02:37:30 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Pablo Palazon , emacs-orgmode@gnu.org Subject: Re: [PATCH] Add margin option to float for figure in ox-latex.el In-Reply-To: Date: Sat, 16 May 2020 06:37:29 +0000 Message-ID: <87o8qoqtau.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B7389E68-973F-11EA-93C1-D1361DBA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/16 02:37:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Thomas S. Dye" , Louis Gostiaux Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=UaNetcyW; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=DsvUOjwh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 2.99 X-TUID: 8UFSPe2jv962 Pablo Palazon writes: > I've created a path to add a new option to float properties for figures on > latex. This is my first change for org-mode, and I don't really sure if > this is the correct way to do it. Thank you! > * lisp/ox-latex.el (org-latex--inline-image): Include margin option > to create marginfigure environment for figures. It's useful for tufte > latex class, where with this environment shows the figure in the margin. I wondered if something like this had been proposed or discussed before. Searching the list, I see a patch [0] very similar to yours from a couple of months back that didn't get a response (author added to cc). Further back, there is a thread about an exporter Thomas Dye (+cc) wrote to handle marginfigure and some other Tufte-y things [1]. It looks like the code is available at , though I'm not sure if it still works with the current Org. As for the proposed patch, while I think the specific code change itself looks fine, skimming through the above thread makes me think that adding marginfigure to ox-latex.el without considering similar cases may not be the right approach. What do others think? [0]: https://yhetil.org/orgmode/35aac187-b751-5723-0f15-be6605fb8ea2@free.fr/ [1]: https://yhetil.org/orgmode/m2h9hsgdo2.fsf@tsdye.com/