emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Seth Lee <lee.seth@protonmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Update ob-haskell from deprecated inf-haskell-mode to haskell-interactive-mode
Date: Sun, 26 Jul 2020 21:29:34 -0400	[thread overview]
Message-ID: <87o8o1ycch.fsf@kyleam.com> (raw)
In-Reply-To: <onq-fWMuc9bRaF1bHpnyIWVmktxe6h3ZNWws91JFxcjHrfaieKssqSrTrJaZVhdCQqH03Vt1TYPBBpFad540MaPZKUlDZQY3TTONqsP911Q=@protonmail.com>

Seth Lee writes:

> Issue: compiling code in a source block that had an infinite list that
> would evaluate in the ghci.  All code, even with `:compile` flag set
> would be run in ghci.
>
> Updating deprecated `inf-haskell-mode` to `haskell-interactive-mode`
> solves the issue for me.
>
> Source blocks flagged to compile will compile in a temp file, and
> those flagged otherwise will be run interactively. This is the
> intended behaviour.
>
> Patch attached.

Thanks for the patch.

> Subject: [PATCH] ob-haskell.el: Update deprecated functions
>
> * lisp/ob-haskell.el: Update to haskell-interactive-mode from inf-haskell-mode
>
> Deprecated commands from inf-haskell mode would send source blocks
> flagged to compile to the interpreter instead of compiling in a temp
> file.
>
> TINYCHANGE

I admit that I don't really have a good understanding of the situation
but...

> ---
>  lisp/ob-haskell.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ob-haskell.el b/lisp/ob-haskell.el
> index 84e2d6c42..01d658615 100644
> --- a/lisp/ob-haskell.el
> +++ b/lisp/ob-haskell.el
> @@ -43,9 +43,9 @@
>  (require 'comint)
>  
>  (declare-function haskell-mode "ext:haskell-mode" ())
> -(declare-function run-haskell "ext:inf-haskell" (&optional arg))
> +(declare-function run-haskell "ext:haskell-interactive-mode" (&optional arg))
>  (declare-function inferior-haskell-load-file
> -		  "ext:inf-haskell" (&optional reload))
> +		  "ext:haskell-process-load-file" (&optional reload))
>  (declare-function org-entry-get "org" (pom property &optional inherit literal-nil))

... I'm confused that the patch consists solely of modifying
declare-function calls.  While that can appease the Emacs byte-compiler,
I'm not seeing how it could relate to the problem you describe.

     prev parent reply	other threads:[~2020-07-27  1:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 17:05 [PATCH] Update ob-haskell from deprecated inf-haskell-mode to haskell-interactive-mode Seth Lee
2020-07-27  1:29 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8o1ycch.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=lee.seth@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).