From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MMkTOciJZmLZKgEAbAwnHQ (envelope-from ) for ; Mon, 25 Apr 2022 13:45:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kIQHOciJZmJHcQEA9RJhRA (envelope-from ) for ; Mon, 25 Apr 2022 13:45:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AE6441B7D for ; Mon, 25 Apr 2022 13:45:12 +0200 (CEST) Received: from localhost ([::1]:34086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nix9T-0000hn-Lk for larch@yhetil.org; Mon, 25 Apr 2022 07:45:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nix8R-0000hf-Hw for emacs-orgmode@gnu.org; Mon, 25 Apr 2022 07:44:07 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:36489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nix8P-00011X-R0 for emacs-orgmode@gnu.org; Mon, 25 Apr 2022 07:44:07 -0400 Received: by mail-pl1-x633.google.com with SMTP id q8so3233653plx.3 for ; Mon, 25 Apr 2022 04:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=JjeBZwZuTpZeBlneDbXqU6KusKzwBGpn2wkvxZXaUxcj6xOIQ8/NLUmKpd4JCk5wzd fRWEYGaocGrVLA9BENeLOH74MCfhIDRlbaOac9RS3Hvmtu4U4ps6A4lRacFWESNN47ng smg7LkgO7vXDXJVtIaj5wWbfZ1pBQ1YktUgNhgmkxlgzeOyU+Uje6nP5qatK+PvFbFWD g5nQ/gQMCDJKzPTpJceSgkd5Ayj7i+yJVGvMyZeECv4Er/2TXgLhyTtwot6hTcv/Bzg9 VgYQvqHthgmlljDpct4DUtQd/AsMgfZEyem4KED2GVyt23H8v4OiFH4nxV9OUB9RMkbR 2k2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=tgFGv26xwR5b3ZHAh9VMMc1u5fJXFZGHrEzoGOuly1MyPHMiF2xtygHZs1YbA17o+c NstnWXXSmp7NIunJ1uorNZM+bakSsq2frsNS4ZkZ1MjATGSwoTCq2WoHXzxmPZvQ3YJC rCPRnogQHh6Jv4V5BzSbd+gKQZ1THebY3FwFIQbQMU4IHw6BY1oQHTmrjU4sOV7le0f6 0JZBzOpjPItbtbOo3swVb5x2U1XeVXk8AoMlcW7QE6zu3mwwny9pJObSElQBMCjeYakU 0GCqyvTHrsB/gC2chvJqTnaO9ZJP+V02i0Axk2TjSU6HbQ/Npas8XzdXzTyk3k39uD+P oGWw== X-Gm-Message-State: AOAM532uLxGkMsEaidV2W9Wesno4EveVGFho1JZcOdEJ0/Wo/TgQcV3Z JIFZa2SKK50fZqwbU+ZfazU= X-Google-Smtp-Source: ABdhPJy2n5EssiAB4Hn5op5HUnOPVWthazy4MtFYdOL5VJexI7LaTUTz31Zhy9D45vZRkH8AH3+1AA== X-Received: by 2002:a17:90b:1251:b0:1d7:f7ae:9f1 with SMTP id gx17-20020a17090b125100b001d7f7ae09f1mr18976783pjb.65.1650887040690; Mon, 25 Apr 2022 04:44:00 -0700 (PDT) Received: from localhost ([63.143.61.57]) by smtp.gmail.com with ESMTPSA id 64-20020a17090a0fc600b001d5f22845bdsm14707495pjz.1.2022.04.25.04.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 04:43:59 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch In-Reply-To: <8735i5gd8n.fsf@gmail.com> References: <87a6f84edg.fsf@localhost> <8735i5gd8n.fsf@gmail.com> Date: Mon, 25 Apr 2022 19:44:51 +0800 Message-ID: <87o80pv13g.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=yantar92@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650887112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=Y+k6IfPr+6pN0KqYeHSjlEn93NRlwS0hu4EA8XrBWV9mbXky8ma+ZwxnFeig6LuzJs0URh 4xOh41/mipOTCyRiFZMPg9QXa+PXSBhw5FDAGFbd9QjPR47Zb7Es9VAEqh1c+9+gc90Nhf azR2cNLLrBSueOzjKh9lFpoHa8gTJ0ku7V7xyzCVA72fja/UEdvSi6t7pSYGCXuoBFAgZE a6pSH3E1ruzDEDGJSmYSYeHm+D7WhriusFRYN86jVx70zcyUox4Vvn6GdMMklDDyQHfzhk d8K/L/IenUluql/uMsvRPfttdWiD/dP85AADB+tlbUTAaBxTBb22eVhmLx1CZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650887112; a=rsa-sha256; cv=none; b=lXIwgcQy8E1I7pG8gIH+wDUjinICywwH6j1dWElHPejBR+vjaks7gx2jzCbDJdukP+kfm/ JDPPkQQyBD0ZezB9OcA4xpETATleQPDj5+3+JL2wvfgVpicXDxODlOUfuZdZoMscZmGzr+ /SDKMABYBAGtyM660wllo80XEW/x7jIojHpU/SbwUWX1ZCdcxr7kVf95LyVp9vl45YQQvf hCj9m+3VnExPoxHv01fivnq1hr6iVPgmUXgYAv8othLPuBy2v6JLPMvEFbo0KAtE42RtZN BdHXpwMTyAiDa5rMYGuNfsNaZG1X+Z5/OQrRPhNqViWBadcwnrXvB1mMDBp6yQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JjeBZwZu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JjeBZwZu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8AE6441B7D X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: CB/oAw4N8B1D I think I addressed the raised issues. Just merged org-fold upstream. K=C3=A9vin Le Gouguec writes: > My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): > > $ git switch feature/org-fold-universal-core-tidy > $ make autoloads > $ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org > > Restarting Emacs with the above between each step: > > (1) C-s abc =E2=87=92 no logbook is unfolded, > (2) C-s def =E2=87=92 no logbook is unfolded, > (3) C-s ghi =E2=87=92 some logbooks are unfolded. > > Assuming you can reproduce: is it expected that logbooks are expanded in > case (3)? I don't see what's "conceptually" different in situation (3) > vs. (1) and (2), so I'm puzzled to get different results. I had a hard time to reproduce your recipe because it was related to font-locking. The only way was increasing the font size, so that line widths were larger than the frame width. I believe I fixed the issue now. > Also, a bit of idle curiosity: > >> (defun org-fold--isearch-reveal (&rest _) >> "Reveal text at POS found by isearch." >> (org-fold-show-set-visibility 'isearch)) > > org-fold-show-set-visibility calls either > org-fold-show-set-visibility--overlays, or > org-fold-show-set-visibility--text-properties, and AFAICT neither of > these handle 'isearch as an argument=E2=80=A6 Is there a (cdr (assq 'ise= arch > org-fold-show-context-detail)) missing? > > (This comes from a very cursory reading of the code; apologies if I've > missed something) You are right. I supposed to use org-fold-show-context. Fixed now. Best, Ihor