emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] The latest org-fold feature breaks link :activate-func property
@ 2022-04-28  3:12 Christopher M. Miles
  0 siblings, 0 replies; 5+ messages in thread
From: Christopher M. Miles @ 2022-04-28  3:12 UTC (permalink / raw)
  To: Org Mode


[-- Attachment #1.1: Type: text/plain, Size: 505 bytes --]


I use extension [[https://repo.or.cz/org-link-beautify.git][org-link-beautify]] to display text-property beautify content on link. With
latest org-mode source code on commit "1ed9e4223", I got this error which displayed in the
attachment gif.

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3


[-- Attachment #1.2: CleanShot 2022-04-28 at 11.11.00.gif --]
[-- Type: image/gif, Size: 1293182 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] The latest org-fold feature breaks link :activate-func property
       [not found] <626a07ec.1c69fb81.8e026.87b0SMTPIN_ADDED_BROKEN@mx.google.com>
@ 2022-04-28  3:55 ` Tim Cross
  0 siblings, 0 replies; 5+ messages in thread
From: Tim Cross @ 2022-04-28  3:55 UTC (permalink / raw)
  To: Christopher M. Miles; +Cc: Org Mode


"Christopher M. Miles" <numbchild@gmail.com> writes:

> [[PGP Signed Part:Undecided]]
>
> I use extension [[https://repo.or.cz/org-link-beautify.git][org-link-beautify]] to display text-property beautify content on link. With
> latest org-mode source code on commit "1ed9e4223", I got this error which displayed in the
> attachment gif.

That animated gif is not terribly helpful. A backtrace would likely
provide something more concrete to work with. As this is something which is
triggered by an external package not part of org mode, you probably need
to report it to the maintainer of that package. 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] The latest org-fold feature breaks link :activate-func property
       [not found] <626a0713.1c69fb81.a3583.1a07SMTPIN_ADDED_BROKEN@mx.google.com>
@ 2022-04-28  6:41 ` Ihor Radchenko
  2022-04-28  8:17   ` Tim Cross
  2022-04-29  0:55   ` [DONE] " Christopher M. Miles
  0 siblings, 2 replies; 5+ messages in thread
From: Ihor Radchenko @ 2022-04-28  6:41 UTC (permalink / raw)
  To: numbchild; +Cc: Org Mode

"Christopher M. Miles" <numbchild@gmail.com> writes:

> I use extension [[https://repo.or.cz/org-link-beautify.git][org-link-beautify]] to display text-property beautify content on link. With
> latest org-mode source code on commit "1ed9e4223", I got this error which displayed in the
> attachment gif.

I do not see any error there, except the fact that Org reveals the links
contents.

Looking at ol.el, it appears that org-next-link does not respect
org-fold-show-context-detail (`link-search'). I fixed this problem on
main.

Let me know if you were referring to something else.

Best,
Ihor


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BUG] The latest org-fold feature breaks link :activate-func property
  2022-04-28  6:41 ` [BUG] The latest org-fold feature breaks link :activate-func property Ihor Radchenko
@ 2022-04-28  8:17   ` Tim Cross
  2022-04-29  0:55   ` [DONE] " Christopher M. Miles
  1 sibling, 0 replies; 5+ messages in thread
From: Tim Cross @ 2022-04-28  8:17 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Org Mode


Ihor Radchenko <yantar92@gmail.com> writes:

> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> I use extension [[https://repo.or.cz/org-link-beautify.git][org-link-beautify]] to display text-property beautify content on link. With
>> latest org-mode source code on commit "1ed9e4223", I got this error which displayed in the
>> attachment gif.
>
> I do not see any error there, except the fact that Org reveals the links
> contents.
>

the gif attachment is an animated gif, so you need to view it in a
client or other program which will 'run' animated gifs. Even when you
do, it doesn't provide much to go on. 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [DONE] Re: [BUG] The latest org-fold feature breaks link :activate-func property
  2022-04-28  6:41 ` [BUG] The latest org-fold feature breaks link :activate-func property Ihor Radchenko
  2022-04-28  8:17   ` Tim Cross
@ 2022-04-29  0:55   ` Christopher M. Miles
  1 sibling, 0 replies; 5+ messages in thread
From: Christopher M. Miles @ 2022-04-29  0:55 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Org Mode

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]


Ihor Radchenko <yantar92@gmail.com> writes:

> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> I use extension [[https://repo.or.cz/org-link-beautify.git][org-link-beautify]] to display text-property beautify content on link. With
>> latest org-mode source code on commit "1ed9e4223", I got this error which displayed in the
>> attachment gif.
>
> I do not see any error there, except the fact that Org reveals the links
> contents.
>
> Looking at ol.el, it appears that org-next-link does not respect
> org-fold-show-context-detail (`link-search'). I fixed this problem on
> main.

Yes, that's the problem. I pulled that latest commit and confirmed the problem fixed. Thanks for
quick response!

>
> Let me know if you were referring to something else.
>
> Best,
> Ihor


-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-29  0:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <626a0713.1c69fb81.a3583.1a07SMTPIN_ADDED_BROKEN@mx.google.com>
2022-04-28  6:41 ` [BUG] The latest org-fold feature breaks link :activate-func property Ihor Radchenko
2022-04-28  8:17   ` Tim Cross
2022-04-29  0:55   ` [DONE] " Christopher M. Miles
     [not found] <626a07ec.1c69fb81.8e026.87b0SMTPIN_ADDED_BROKEN@mx.google.com>
2022-04-28  3:55 ` Tim Cross
2022-04-28  3:12 Christopher M. Miles

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).