From: Timothy <firstname.lastname@example.org> To: Max Nikulin <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] New remote resource download policy Date: Wed, 29 Jun 2022 23:27:59 +0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 1563 bytes --] Hi Max, Max Nikulin <email@example.com> writes: >>> I see your intention to add something fancy to the dialog. May `org-mks’ be >>> reused instead to avoid proliferation variants of rather similar UI code? >> Well, the thing here is that I’m explicitly trying to mimic the >> file-local-variable dialog, and since a general form isn’t exposed by Emacs, a >> little bit of proliferation seems like the best option to me. > > From my point of view the result is rather close (prompt should be adjusted): > > (let ((uri “<https://orgmode.org>”)) > (org-mks > nil > (format “An org-mode document would like to download %s, which is not > considered safe. > > Do you want to download this?” > (propertize uri ’face ’(:inherit org-link :weight normal))) > nil ; prompt > `((,(propertize “!” ’face ’success) > “download this resource, and permanantly mark it as safe.”) > (,(propertize “y” ’face ’warning) > “to download this resource, just this once.”) > (,(propertize “n” ’face ’error) > “skip this resource.”)))) I just tried this snippet and it looked quite different to me, that said I have tweaked `org-mks' a bit in my config… (I initially found org-capture quite ugly). I also really don’t like how `org-mks' so forcefully grabs all keyboard input. I can see it being nice to jump back to the buffer and see where the resource is being used, which isn’t really possible using `org-mks'. All the best, Timothy
next prev parent reply other threads:[~2022-06-29 15:34 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-12 14:43 Timothy 2022-06-12 16:18 ` Daniel Fleischer 2022-06-14 9:40 ` Robert Pluim 2022-06-22 9:58 ` Timothy 2022-06-15 12:35 ` Max Nikulin 2022-06-22 10:01 ` Timothy 2022-06-22 16:55 ` Max Nikulin 2022-06-29 15:27 ` Timothy [this message] 2022-06-30 16:57 ` Max Nikulin 2022-07-16 9:47 ` Timothy 2022-06-25 7:50 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] New remote resource download policy' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).