From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CGAPC5RlLGOKPwAAbAwnHQ (envelope-from ) for ; Thu, 22 Sep 2022 15:39:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ADP0CpRlLGOyWgEAauVa8A (envelope-from ) for ; Thu, 22 Sep 2022 15:39:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF9733D90C for ; Thu, 22 Sep 2022 15:39:31 +0200 (CEST) Received: from localhost ([::1]:45294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obMQM-00073n-Tb for larch@yhetil.org; Thu, 22 Sep 2022 09:39:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obLbi-0004F3-LK for emacs-orgmode@gnu.org; Thu, 22 Sep 2022 08:47:15 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:34383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obLbc-00011Z-6Y for emacs-orgmode@gnu.org; Thu, 22 Sep 2022 08:47:08 -0400 Received: by mail-qk1-x72e.google.com with SMTP id g2so6067460qkk.1 for ; Thu, 22 Sep 2022 05:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:from:to:cc:subject:date; bh=H5rf7rKkNA1J1FETgPW2HavCvkdWu4jqozIFEY4767A=; b=gTRXtnHpGxZia9ibPfqMkuUcyYmeUI9zgrlU7vo/YDepsKAANtG59O+3aDhrANCTEF XHfSYOT8yNNk3SZUfCCGDbSb49dvE+gI+RNiAb3udw/c8dIlWV3zczPO+l+DGexKBrgs p+iBatD27U3Pa1gx50/TGDYvWZT9XpvnPyt1XhSy9ZzKjMqxlYdMkHB8ouWDfY31KnxH G7TxhwkFUzdHkNq2dxLsSgDBP7tXtPAMI9eJYd0NL3tH32pB7zAGVxTDKdGJqALGcJJr JJVgbstySBmb9xMf42eitlETrbtTqz5J1iWkjw8KKmWTjYwvOBRtBvY9ICg7gVMCAWAG eXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date; bh=H5rf7rKkNA1J1FETgPW2HavCvkdWu4jqozIFEY4767A=; b=v+7LGgGzsOOTDIgnuEPvPvEKi9/ISFMXmyH/W7ls8GeWp0lo4gySISVssMsdt/uylK kbpK3MPJP4v2ycLgrWHy9ONKsgLVNvD/MG6eGQLe8ehjeb0uXDT22kl9WrZmGVR8mzqb i1N1gZsQHjdP4qwmUyikNOu3Kl/ujZaOvylyFnWje/H4NbxUNhW/GT7T83lNv1gTYtvK C3G9jxurxtr3lyPsQLFBspQaCt/3gU9rzmght06iR+lFMSGKjDpAnCHI4uAFo1gY1GUw UdW3EIEuSg8q9HCqekmWkKOuIq6hEBRjJSVwNmrVJVUUHVJwv96Y4vXpdpg35mvqmgWp UbdA== X-Gm-Message-State: ACrzQf2l4Qv4RuO95JtFrxBdcMMPNY6FNFORJWYlzHyvxaGxyloFkAb6 XW7Hpflehquqvj5LzrAAzuRJHYztIT4l9A== X-Google-Smtp-Source: AMsMyM6Q9sdQnllWUcavLxPiMaVKIVMCaLMAK+/EH0A5Ks5ZJXo5BQz/UAaAAVTGYjxJqnC+GH1P2g== X-Received: by 2002:ae9:c103:0:b0:6ce:1a9f:9f76 with SMTP id z3-20020ae9c103000000b006ce1a9f9f76mr1950823qki.306.1663850819806; Thu, 22 Sep 2022 05:46:59 -0700 (PDT) Received: from tyler-fedora ([2600:6c48:69f0:5f0::14f4]) by smtp.gmail.com with ESMTPSA id i12-20020a05620a404c00b006b8d1914504sm4506173qko.22.2022.09.22.05.46.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 05:46:58 -0700 (PDT) From: Tyler Grinn To: emacs-orgmode@gnu.org Subject: Re: contrib - ol-todo In-Reply-To: <87y1ueqwwz.fsf@localhost> (Ihor Radchenko's message of "Tue, 20 Sep 2022 16:20:44 +0800") References: <87edwax4nv.fsf@gmail.com> <87y1ueqwwz.fsf@localhost> Date: Thu, 22 Sep 2022 08:46:57 -0400 Message-ID: <87o7v7injy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=tylergrinn@gmail.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663853971; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=H5rf7rKkNA1J1FETgPW2HavCvkdWu4jqozIFEY4767A=; b=o4B7s+5q+i2F+vuIaQVg/oPGk5HZOiP9QjOqpUja2kj64kRlvHMXPv9GjfNL4HRyDlKkX7 zdjfst3tACQeEE0EYITi8klI3yiifoGXVdWh9/Loa4K1pqPiaYMY+NYQiKix1wbI86eUdW 8tOLjx/1qIEuHrSyhX8bp9+0fpsTPyxrwYtcMjehLb9yh9H6Ew4mJdbYZCs23FzmdmttkR MSeOySSZt9NwKLivA9kf8RmNvxE7nM4x8BapBplkPs98H05y41N4v1F0SKhL8ArmtPymbU Eixn6t5WBqdlGtUQ6Sy83Z5KpIdQEEvZzWqziHRGpiqhM07S6ESOzeXIZduzag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663853971; a=rsa-sha256; cv=none; b=XFYeOrzzzcqndG7g+zf+6TuDrngqHntwxcsGY98S3sJXds4x+TCxrwV0QqD2WkLZtTxO0B diPSerRfCmoiX9YZ3v6b4aqIbuVsNAutO51CdRf1/hwbLHdLBPKbb8ZEmzbCNR/qrShO37 RKWPLb2BO9n0QTgTLgf6O4AJf+37Bu7/XycEdVYRjqRQr8G8TaGoEit16EGbYT2Y3dtNaL ep2fTcBIt/jz3hSRzoDHRMj6c5icsLP4Go5GDLFIcOCYoNihK4eljyqx+mGcKXntrMF1Hy qez+1WM3m3bt1ZO6Fyom8zKAhZhJ3tCSEZ6FXE9ixV8MHOul5JOm0KB0T8kt5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gTRXtnHp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.65 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gTRXtnHp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BF9733D90C X-Spam-Score: -5.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4TqasSGmInG0 Ihor Radchenko writes: I've moved the project to gitlab: https://gitlab.com/tygrdev/org-todo-link > Why don't just modify :activate-func in the ordinary file links? I like this idea, in fact so much I got rid of the todo style link. But one thing that's still problematic is that I'd like org-todo-link-mode to be a local mode but for some reason make-local-variable isn't working how I expect for org-link-parameters: (define-minor-mode org-todo-link-mode "Display TODO keyword, if it exists, for all file+heading links." :lighter " todo-link" (if org-todo-link-mode (progn (make-local-variable 'org-link-parameters) (org-link-set-parameters "file" :activate-func #'org-todo-link-activate) (org-restart-font-lock)) (kill-local-variable 'org-link-parameters) (org-with-wide-buffer (mapc #'delete-overlay (seq-filter (lambda (ov) (overlay-get ov 'ol-todo)) (overlays-in (point-min) (point-max))))) (org-restart-font-lock))) What I expect to happen is that in the current buffer, the file link type will have the activate-func, but in other buffers not. Instead org-link-parameters is modified globally. Maybe this is a better question for emacs-devel, but do you know of a way to set org-link-parameters buffer-locally?