From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6NDaEVM8W2N7XwEAbAwnHQ (envelope-from ) for ; Fri, 28 Oct 2022 04:20:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8KbFEVM8W2MIYQEA9RJhRA (envelope-from ) for ; Fri, 28 Oct 2022 04:20:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7BFF2969A for ; Fri, 28 Oct 2022 04:20:02 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooExQ-0002nR-2o; Thu, 27 Oct 2022 22:18:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooExO-0002n6-1s for emacs-orgmode@gnu.org; Thu, 27 Oct 2022 22:18:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooExM-0004nU-1j for emacs-orgmode@gnu.org; Thu, 27 Oct 2022 22:18:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5709C240026 for ; Fri, 28 Oct 2022 04:18:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666923525; bh=drqXE7Dkrd7LoVIH/MfVe8CaWvADqZOS/UcJPMeQ23w=; h=From:To:Cc:Subject:Date:From; b=oQucXCQqNJBRbIYp84mxmpeIBVZBbQK/zL5tNJQSnaHnOQD9Gt4vEtWq2ObprBjp/ xnFyh7JfAyVNrfOSEzOgjFmWLggBwn5k0EYmyaBrOYC1bwr5o3mueOhnmqd2rBwFsu QvKEex36xv1bWjFPQmmmgupNcu+9x681f1Ea+hnochASgA1ofdtQn2/BPvPq90LqTk Mv158eVL+Ne6GzbPchV++RtFsQT+ntvKwdW4VreXTy9vKlWWjHQxRxd568srVizLiP myhOA0F/TTjkJimk1x/M4Cu9n5zsJlr9tPpYmqEaD2hu/CNs42lFXBtOpnc0BL6LPt PaDo6N9Vxa2oA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mz5nb556Vz9rxB; Fri, 28 Oct 2022 04:18:43 +0200 (CEST) From: Ihor Radchenko To: dziltener@lyrion.ch Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option In-Reply-To: <20221026193733.14725-1-dziltener@lyrion.ch> References: <20221026193733.14725-1-dziltener@lyrion.ch> Date: Fri, 28 Oct 2022 02:19:26 +0000 Message-ID: <87o7twn101.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666923603; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O4VZ/zH1bwJfATG5H3KXGDtSd3aa6YnkNHD4Kt8Saok=; b=ZQ8BUXarcFd05vlD5H7RBpy+WNcnVox3DeqoSJUI/pUChNhbxNwLTpYVuO97DddIW1QT9m DGYw/BgYv0orciBAGyTPD2K2Hphr9IbJMdXEGqDr7MMXmLUorH/w1jFZEltRzEGIFWKfFZ iFk7bkqNjuSlWMWMTHqVY+nLiX1CQC9xBONZbi3v0yCy2V4VyN0DE3/uIE8sz4Boc1QSX8 SRtSpf17PmuqI5Rx2xPDICeVwNACq7HsvanWR79BH6niuFkdTLtQa8boJwQ4OtvAizC4jN qgbf+PirSOR+wQwTXKZEb6QdoBpHBjOjspIqJ8Es1d8crpdo5SMEbPLKyGrYAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666923603; a=rsa-sha256; cv=none; b=J+jwajPSVexN+naYaWVoMq9z36JpLrg3zPyfl/GILWohu/bh+cgLIULVF/MxSzugrg2r4e V22dan+03+bE0f2KNT4nf9vejnRdvTMF4oSmZ0yKEKGvhKM7Dy1r52AOJquRreQqAA+jD4 tcoNe9TsyQHM6UE3X3WWc0f63b6YMjJrFFw39B13zBlZit8v9dYuhNsu8XWXIUlrs3YYcP B7hC1P5Xrj3qorGvukGIASPvxlMLR5bQF7GocxW1DI2gnDyydHuPlvC+x/lDGjFYMySPqn bkMP+aJWCrUSeARPp77xwgMnvE76QlGzl2TuJKf/2IdYqNEAQTGZpPqnwo0ACQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oQucXCQq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oQucXCQq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A7BFF2969A X-Spam-Score: -2.11 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8Xg+64IMvSWO dziltener@lyrion.ch writes: > From: Daniel Ziltener > > * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a > "strip-tangle" noweb option to strip the noweb tags when tangling, but > keep and expand them otherwise. Thanks for the patch! If I understand correctly, you are suggesting Could you please follow https://orgmode.org/worg/org-contribute.html#commit-messages for the commit log entries? Also, do you have FSF copyright assignment? If no, you also need to add TINYCHANGE cookie to the commit message. See https://orgmode.org/worg/org-contribute.html#first-patch > +- =strip-tangle= :: > + > + Expansion of noweb syntax references in the body of the code block > + when evaluating or exporting. Removes noweb syntax references > + when tangling. This is a new feature and thus should also be mentioned in etc/NEWS. Also, please use double space between sentences. See doc/Documentation_Standards.org. > (let ((allowed-values (cl-case context > - (:tangle '("yes" "tangle" "no-export" "strip-export")) > - (:eval '("yes" "no-export" "strip-export" "eval")) > - (:export '("yes"))))) > + (:tangle '("yes" "tangle" "no-export" "strip-export" "strip-tangle")) > + (:eval '("yes" "no-export" "strip-export" "eval" "strip-tangle")) > + (:export '("yes" "strip-tangle"))))) AFAIU, you are suggesting a new value for :noweb header argument. But this function has nothing to do with :noweb. This change will check for :tangle strip-tangle, :eval strip-tangle, and :export strip-tangle. What is the purpose? Also, the allowed values of standard header args are defined in org-babel-common-header-args-w-values, which you did not change. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at