From: Ihor Radchenko <yantar92@posteo.net>
To: dziltener@lyrion.ch
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option
Date: Fri, 28 Oct 2022 02:19:26 +0000 [thread overview]
Message-ID: <87o7twn101.fsf@localhost> (raw)
In-Reply-To: <20221026193733.14725-1-dziltener@lyrion.ch>
dziltener@lyrion.ch writes:
> From: Daniel Ziltener <dziltener@lyrion.ch>
>
> * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
> "strip-tangle" noweb option to strip the noweb tags when tangling, but
> keep and expand them otherwise.
Thanks for the patch!
If I understand correctly, you are suggesting
Could you please follow
https://orgmode.org/worg/org-contribute.html#commit-messages for the
commit log entries?
Also, do you have FSF copyright assignment? If no, you also need to add
TINYCHANGE cookie to the commit message. See
https://orgmode.org/worg/org-contribute.html#first-patch
> +- =strip-tangle= ::
> +
> + Expansion of noweb syntax references in the body of the code block
> + when evaluating or exporting. Removes noweb syntax references
> + when tangling.
This is a new feature and thus should also be mentioned in etc/NEWS.
Also, please use double space between sentences. See
doc/Documentation_Standards.org.
> (let ((allowed-values (cl-case context
> - (:tangle '("yes" "tangle" "no-export" "strip-export"))
> - (:eval '("yes" "no-export" "strip-export" "eval"))
> - (:export '("yes")))))
> + (:tangle '("yes" "tangle" "no-export" "strip-export" "strip-tangle"))
> + (:eval '("yes" "no-export" "strip-export" "eval" "strip-tangle"))
> + (:export '("yes" "strip-tangle")))))
AFAIU, you are suggesting a new value for :noweb header argument.
But this function has nothing to do with :noweb. This change will check
for :tangle strip-tangle, :eval strip-tangle, and :export strip-tangle.
What is the purpose?
Also, the allowed values of standard header args are defined in
org-babel-common-header-args-w-values, which you did not change.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-28 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:37 [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option dziltener
2022-10-28 2:19 ` Ihor Radchenko [this message]
2022-10-28 8:09 ` Daniel Ziltener
2022-10-29 3:49 ` Ihor Radchenko
2022-10-29 23:34 ` Daniel Ziltener
2022-10-30 4:12 ` Ihor Radchenko
2022-10-30 10:42 ` Daniel Ziltener
2022-11-02 6:17 ` Ihor Radchenko
2022-12-27 10:59 ` Ihor Radchenko
2022-10-30 4:17 ` Timothy
2022-10-31 3:24 ` Ihor Radchenko
2022-10-31 3:31 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7twn101.fsf@localhost \
--to=yantar92@posteo.net \
--cc=dziltener@lyrion.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).