From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aKpSJyVuzmOPRQEAbAwnHQ (envelope-from ) for ; Mon, 23 Jan 2023 12:23:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yDN+JiVuzmOV6AAAG6o9tA (envelope-from ) for ; Mon, 23 Jan 2023 12:23:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DE0E10061 for ; Mon, 23 Jan 2023 12:23:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJuuJ-0008Ed-L8; Mon, 23 Jan 2023 06:22:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJuuG-0008EV-PA for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 06:22:32 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJuuE-0001gH-Fs for emacs-orgmode@gnu.org; Mon, 23 Jan 2023 06:22:32 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4EDDD2403E4 for ; Mon, 23 Jan 2023 12:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1674472948; bh=y3HkoyAhln0MCR2Ula3ZIfyF+Xa39xHrhIuwxgm5p7M=; h=From:To:Cc:Subject:Date:From; b=UmjtuLfAZW4qRlziWI9c3MSW0R2zOUyZDNH5Wemhm0dKloWZr1mc4pH070Is5Mm0L wPi+Bjf8q0w7boSZFxMJMFzM5rmsb/uTdhqpbVvC6c0d4BePSihZtaem6rs5oHAh3H z9LSfJ0+aO5v3bAi6C4DmFA483E3n40N4UZakNwWZGu5Da6a92QgU8L+PbkNryQP4M 28gtakQD0T4QsqF+TbnTQ7ac+XuSTfaW4lprfXyus1DDbDjUltGpdQN+RhYogas6WY TMt8Y9dzlZN0wmpZmF/O+SfHqZWDxrQqcNo4RJbS0Oms1y122vbrIwA0H08QcEImr8 WVNYpqMjhHHyA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P0nkq1LVfz9rxP; Mon, 23 Jan 2023 12:22:26 +0100 (CET) From: Ihor Radchenko To: Jack Kamm Cc: Bastien Guerry , emacs-orgmode@gnu.org Subject: Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? In-Reply-To: <877cxe2ot2.fsf@gmail.com> References: <87bkprid1d.fsf@localhost> <87mt9am16j.fsf@gmail.com> <87r0yk7bx8.fsf@localhost> <87r0xqla74.fsf@localhost> <87r0xq8dk9.fsf@gnu.org> <87wn6atjid.fsf@localhost> <877cxe2ot2.fsf@gmail.com> Date: Mon, 23 Jan 2023 11:22:59 +0000 Message-ID: <87o7qp5wbw.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674472997; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QWANdHKclTy7ms0rbHFNuYmh0+PcbHZc9sBdyPWb2hE=; b=N3LRm4VzgfF3WSjIntwrC8FFyxBApR+48W8ADQsu8dhP04LagOr1Q85DPamA7OASZHGXsS PGbkteC/FPUvAZdLBFv6zfowCuaa9WpiOU3sRJF1xy3aSTIC0FKxKSg8YAZABT07g0rOlS 7HWci0fd3a8o4tJeXf2SH/CqkWkB2nGHEXdqCNnBDYarNqtpqV8ErBtGhws29YNDqcFdaM jfTCJrFLxfK+8MvMQOZwNypCRT8jMj3zr8SIT+vw7fOVfgugoBPfw2sBxm1Qw84BatQoV/ wXHyGjv77aR+8OK457fvV04pj/1/WhUI9myX5r9PPkgEfjnZghqEXS54GltOcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UmjtuLfA; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674472997; a=rsa-sha256; cv=none; b=r6iqnQYajLgK19216PvIph+vo3HmZrKrae3adn4xcPakpbVO9Of+ehIqMBimO99tAaLQ0X 3cRS7bRdYwDBa//p9BhbfkTmB/morvLK+vHvfjj4quYFWebSNPE8zJMwoaVqr0XCdT09Zj M83HkaVg9SPhNzB/lp3OxNGBNpDaH8nNR24Zv8uhw3UPaZuiO1A/6BYfjlzciB6EQCutHh Z2YpVcLZ+HofE9CshzhjPNs3XJKiSnX3HFZUbVN2ABJhnx023VzjU18aWBSPjlS2hR9iWA pcEX7tNDxAc1OAx69gAVzXbGhtAzjRJx1oUHwAjdoY5ZLruIFhApAiwT8rtypw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -5.05 X-Spam-Score: -5.05 X-Migadu-Queue-Id: 3DE0E10061 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UmjtuLfA; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: ddLF917kAKtT Jack Kamm writes: > Ihor Radchenko writes: > >> Marked for future removal in ob-python.el. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 > > Thanks Ihor. > > Not sure if it's too early for this, but I've prepared a patch to remove > the support for python-mode.el, attached. main branch is for Org 9.7. So, removing it should happen before the next Org 9.7 release on main anyway. I have no objections on this. > Also, to help any python-mode users with the transition, I ported the > code to support python-mode to an external package here: > > https://gitlab.com/jackkamm/ob-python-mode-mode > > As always, feedback is welcome, either on this patch or the external > package. I find the need to use advise awkward. Is it necessary? > Subject: [PATCH] ob-python: Remove python-mode.el support > > * lisp/ob-python.el (org-babel-python-mode): Remove customization > variable. Let's follow the usual approach and first deprecate it. It should become a constant with 'python value in org-compat.el. Deprecating is not make sure that other packages that might be testing the variable value do not get broken. > (org-babel-python-send-string): Renamed from > org-babel-python--send-string, turning it into a public function to > accommodate ob-python-mode-mode which advises this function. Also, > remove some code for python-mode.el Note that we usually `quote' Elisp symbols in the commit messages. Otherwise, the patch looks good. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at