From: "Sławomir Grochowski" <slawomir.grochowski@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [FR] org-colview.el, add annotation for functions summary-types
Date: Fri, 16 Aug 2024 13:13:37 +0200 [thread overview]
Message-ID: <87o75slnz2.fsf@gmail.com> (raw)
In-Reply-To: <87wmkh1y6f.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Ok. But please double-check that it is really the case.
Checked.
So I have those 3 code snipets:
(defun org-columns--summary-types-completion-function (string)
(docstring-first-line
(cdr (assoc string (append
org-columns-summary-types
org-columns-summary-types-default)))))
(completing-read
"Summary: "
(lambda (string pred flag)
(pcase flag
('t (all-completions string
(delete-dups
(cons '("") ;Allow empty operator.
(mapcar #'car (append
org-columns-summary-types
org-columns-summary-types-default))))
pred))
('metadata (list 'metadata
(cons 'annotation-function
'org-columns--summary-types-completion-function))))))
(defun docstring-first-line (fun)
(let* ((doc (condition-case nil (documentation fun) (error nil)))
(doc (and doc (substring doc 0 (string-search "\n" doc)))))
(if doc
(format " -- %s" doc)
"")))
But I have no idea where to put this piece:
(if doc
(format " -- %s" doc)
"")
It should not be in docstring-first-line.
What do you think?
--
Slawomir Grochowski
next prev parent reply other threads:[~2024-08-16 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:53 [FR] org-colview.el, add annotation for functions summary-types Sławomir Grochowski
2024-08-10 13:03 ` Ihor Radchenko
2024-08-15 14:35 ` Sławomir Grochowski
2024-08-15 16:48 ` Ihor Radchenko
2024-08-15 17:29 ` Sławomir Grochowski
2024-08-15 17:41 ` Ihor Radchenko
2024-08-16 11:13 ` Sławomir Grochowski [this message]
2024-08-18 9:56 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o75slnz2.fsf@gmail.com \
--to=slawomir.grochowski@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).