From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Clemente Subject: Re: org-agenda-filter-by-tag doesn't work with custom effort property Date: Wed, 25 Feb 2009 18:32:29 +0100 Message-ID: <87myca4e36.fsf@CPU107.opentrends.net> References: <877i3f6g5v.fsf@CPU107.opentrends.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LcNd0-0006cn-R9 for emacs-orgmode@gnu.org; Wed, 25 Feb 2009 12:33:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LcNcy-0006Z8-TY for emacs-orgmode@gnu.org; Wed, 25 Feb 2009 12:33:02 -0500 Received: from [199.232.76.173] (port=40203 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNcy-0006Yw-OV for emacs-orgmode@gnu.org; Wed, 25 Feb 2009 12:33:00 -0500 Received: from fg-out-1718.google.com ([72.14.220.158]:7623) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LcNcy-0004v6-9i for emacs-orgmode@gnu.org; Wed, 25 Feb 2009 12:33:00 -0500 Received: by fg-out-1718.google.com with SMTP id l27so304863fgb.30 for ; Wed, 25 Feb 2009 09:32:57 -0800 (PST) In-Reply-To: (Carsten Dominik's message of "Wed, 25 Feb 2009 13:51:21 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org El dc, feb 25 2009, Carsten Dominik va escriure: > On Feb 24, 2009, at 3:52 PM, Daniel Clemente wrote: > >> >> Hi, I would like to contribute 1 byte to org-mode; it's an "a": >> >> >> --- a/lisp/org-agenda.el >> +++ b/lisp/org-agenda.el >> @@ -4407,7 +4407,7 @@ to switch to narrowing." >> (lambda (x) (if (cdr x) (char-to-string (cdr x)) "")) >> alist "")) >> (efforts (org-split-string >> - (or (cdr (assoc (concat org-effort-property "_ALL") >> + (or (cadr (assoc (concat org-effort-property "_ALL") >> org-global-properties)) >> "0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 7:00 8:00" > > I don't think this is correct. > > What are the symptoms of the problem you encounter? Before describing the problem: the (or ) was taking either the (cdr ) or = "0 0:10=E2=80=A6". But cdr always return a list (not a string), so if the c= dr is used, the result will be a list, and this is wrong because it org-spl= it-string expects a string, not a list. The problem can be reproduced with: 1. C-c a 2. a 3. / I get: Debugger entered--Lisp error: (wrong-type-argument stringp ("0 0:10 0:30 1:= 00 2:00 3:00 4:00 5:00 6:00 12:00 18:00 24:00 30:00")) string-match("[ \f \n=E2=80=A6]+" ("0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 = 6:00 12:00 18:00 24:00 30:00") 0) org-split-string(("0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 12:00 18:00 = 24:00 30:00")) org-agenda-filter-by-tag(nil) call-interactively(org-agenda-filter-by-tag nil nil) I'm using: (add-to-list 'org-global-properties '("Effort_ALL" "0 0:10 0:30 1:00 2:00 3= :00 4:00 5:00 6:00 12:00 18:00 24:00 30:00")) org-mode 6.21b (from Emacs from Bazaar of 24-2-2009) -- Daniel