emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: / RET filter no longer auto-excludes FILETAGS [6.33trans (release_6.33f.34.gf806)]
Date: Thu, 26 Nov 2009 06:21:09 -0500	[thread overview]
Message-ID: <87my294jmi.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <EA70578D-0FC8-49F2-9047-55D95D35ADAD@gmail.com> (Carsten Dominik's message of "Thu\, 26 Nov 2009 12\:03\:24 +0100")

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Nov 26, 2009, at 11:55 AM, Bernt Hansen wrote:
>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> On Nov 25, 2009, at 7:54 PM, Bernt Hansen wrote:
>>>
>>>>
>>>> My auto exclude functions are inline below:
>>>>
>>>> (defun bh/org-auto-exclude-function (tag)
>>>> (and (cond
>>>> 	((string= tag "@home")
>>>> 	 (bh/working-p))
>>>> 	((string= tag "@office")
>>>> 	 (not (bh/working-p)))
>>>> 	((string= tag "MARK")
>>>> 	 (not (bh/mark-p)))
>>>> 	((or (string= tag "@errand") (string= tag "PHONE"))
>>>> 	 (let ((hour (nth 2 (decode-time))))
>>>> 	   (or (< hour 8) (> hour 21)))))
>>>>      (concat "-" tag)))
>>>>
>>>
>>> do you get it back to when when replacing "MARK" with "mark" and
>>> "PHONE" wiht "phone"?
>>
>> Yes.  When I make the tags lowercase in the function above it works
>> again.
>
> The docstring of org-agenda-auto-exclude-function does mention this,
> but it is indeed a change from John's original code - so it was not in
> the docstring when you wrote this function..

Ah!  Oops.  I was bad and didn't read the contents of commit c6186f4
(Check all represented tags in agenda for auto-exclusion, 2009-11-20)
before submitting the bug report.  I'll try to remember to do that next
time.

This change should probably be described in the upcoming release notes
just so anyone else that already has the function defined won't get
caught by it but I'm sure you're already planning to do that :)
I can't find anything in the Changelog mentioning the case change.

Thanks for the clarification!

Bernt

next prev parent reply	other threads:[~2009-11-26 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 18:54 Bug: / RET filter no longer auto-excludes FILETAGS [6.33trans (release_6.33f.34.gf806)] Bernt Hansen
2009-11-26  6:02 ` Carsten Dominik
2009-11-26 10:55   ` Bernt Hansen
2009-11-26 11:03     ` Carsten Dominik
2009-11-26 11:21       ` Bernt Hansen [this message]
2009-11-26 11:26         ` Carsten Dominik
2009-11-26 11:28           ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87my294jmi.fsf@gollum.intra.norang.ca \
    --to=bernt@norang.ca \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).