From: David Maus <dmaus@ictsoc.de>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] fix infinite loop in csv table import
Date: Tue, 20 Jul 2010 07:30:01 +0200 [thread overview]
Message-ID: <87mxtmk9eu.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <87r5izxkfp.fsf@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]
Eric Schulte wrote:
>Hi,
>I've just noticed that I get an infinite loop when importing csv tables
>into Org-mode tables. For example calling
> (org-table-convert-region (point-min) (point-max) '(4))
>from inside of a simple text file containing the following
>--8<---------------cut here---------------start------------->8---
>1,2,3
>1
>2
>3
>5
>--8<---------------cut here---------------end--------------->8---
>results in an infinite loop. The attached patch fixes this issue [1],
>however it seems weird that this would just surface now, given that the
>code in question has been in the repo since last fall
This patch looks good to me: If the end of the region happens to be
end-of-buffer point will never be greater than end and the loop loops
forever.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2010-07-20 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 20:53 [PATCH] fix infinite loop in csv table import Eric Schulte
2010-07-20 5:30 ` David Maus [this message]
2010-07-20 7:29 ` Patchwork: Patch 159 Accepted Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxtmk9eu.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).