From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: Footnote sorting bug Date: Mon, 07 Mar 2011 18:04:01 -0500 Message-ID: <87mxl6sfby.fsf@fastmail.fm> References: <87y64qsqbj.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=55077 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwjTA-0003bP-Gg for emacs-orgmode@gnu.org; Mon, 07 Mar 2011 18:04:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwjT9-00019E-HL for emacs-orgmode@gnu.org; Mon, 07 Mar 2011 18:04:04 -0500 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:49420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwjT9-000192-Eu for emacs-orgmode@gnu.org; Mon, 07 Mar 2011 18:04:03 -0500 Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.messagingengine.com (Postfix) with ESMTP id F38BC20A0E for ; Mon, 7 Mar 2011 18:04:02 -0500 (EST) Received: from archdesk (67-197-63-212.rh2.dyn.cm.comporium.net [67.197.63.212]) by mail.messagingengine.com (Postfix) with ESMTPSA id 8F6D3405E70 for ; Mon, 7 Mar 2011 18:04:02 -0500 (EST) In-Reply-To: <87y64qsqbj.fsf@fastmail.fm> (Matt Lundin's message of "Mon, 07 Mar 2011 14:06:40 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode Matt Lundin writes: > I traced the problem to an extra forward-line added to > org-footnote-goto-local-insertion-point with commit > 145109dc4a6f161e4ad826bea9cc970363649280. > > The following patch fixes the sorting problem in org buffers. AFAICT, it > has no effect on footnote insertion in message mode buffers with > signatures. (Unfortunately, footnote sorting in message buffers with > signatures is broken both before and after this patch.) > > diff --git a/lisp/org-footnote.el b/lisp/org-footnote.el > index b6a9bca..d28161e 100644 > --- a/lisp/org-footnote.el > +++ b/lisp/org-footnote.el > @@ -511,8 +511,7 @@ ENTRY is (fn-label num-mark definition)." > (beginning-of-line 0)) > (if (looking-at "[ \t]*#\\+TBLFM:") (beginning-of-line 2)) > (end-of-line 1) > - (skip-chars-backward "\n\r\t ") > - (forward-line)) > + (skip-chars-backward "\n\r\t ")) > > (defun org-footnote-delete (&optional label) > "Delete the footnote at point. My apologies. Please disregard this patch. It does not fix the issue and cause problems when creating footnotes. I'll take a closer look at the code when I get a chance. - Matt