* Adjust org-contacts-wl functions to used standards
@ 2011-05-06 10:06 Michael Markert
2011-05-12 18:04 ` Michael Markert
0 siblings, 1 reply; 6+ messages in thread
From: Michael Markert @ 2011-05-06 10:06 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Julien Danjou
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
Hi,
Following the merge of org-contacts-wl with org-contacts I thought it
would be nice to unify the interfaces.
The patches follow separately.
Open Problems:
* Make both accessible through `org-contacts-template-name', I see two (a half) possibilities
1. Use a variable to specify a "name-email" function
2. pass a variable to `org-contacts-template-name' to choose per call
3. half: Use 2. but define functions (per backend) that call with the
appropriate variable
Michael
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Adjust org-contacts-wl functions to used standards
2011-05-06 10:06 Adjust org-contacts-wl functions to used standards Michael Markert
@ 2011-05-12 18:04 ` Michael Markert
2011-05-12 18:25 ` Julien Danjou
0 siblings, 1 reply; 6+ messages in thread
From: Michael Markert @ 2011-05-12 18:04 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Julien Danjou
[-- Attachment #1.1: Type: text/plain, Size: 133 bytes --]
Hi,
I missed a nasty bit: `org-contacts-wl-get-name-email' was not updated
and contained another bug.
:(
Patch appended.
Michael
[-- Attachment #1.2: 0001-Fix-org-contacts-wl-get-name-email.patch --]
[-- Type: text/plain, Size: 1192 bytes --]
From 0417bb6f11828ef55bd451d7523f4f954963bd87 Mon Sep 17 00:00:00 2001
Message-Id: <0417bb6f11828ef55bd451d7523f4f954963bd87.1305223167.git.markert.michael@googlemail.com>
From: Michael Markert <markert.michael@googlemail.com>
Date: Thu, 12 May 2011 19:55:10 +0200
Subject: [PATCH] Fix `org-contacts-wl-get-name-email'.
To: emacs-orgmode@gnu.org
---
contrib/lisp/org-contacts.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index ff4374d..192cb45 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -423,9 +423,9 @@ Depends on Wanderlust been loaded."
(defun org-contacts-wl-get-name-email ()
"Get name and email address from wanderlust email.
See `org-contacts-wl-get-from-header-content' for limitations."
- (let ((from (wl-get-from-header-content)))
+ (let ((from (org-contacts-wl-get-from-header-content)))
(when from
- (cons (wl-address-header-extract-realname from)
+ (list (wl-address-header-extract-realname from)
(wl-address-header-extract-address from)))))
(defun org-contacts-template-wl-name (&optional return-value)
--
1.7.5.1
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: Adjust org-contacts-wl functions to used standards
2011-05-12 18:04 ` Michael Markert
@ 2011-05-12 18:25 ` Julien Danjou
2011-05-12 19:15 ` Michael Markert
0 siblings, 1 reply; 6+ messages in thread
From: Julien Danjou @ 2011-05-12 18:25 UTC (permalink / raw)
To: Michael Markert; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
On Thu, May 12 2011, Michael Markert wrote:
> I missed a nasty bit: `org-contacts-wl-get-name-email' was not updated
> and contained another bug.
> :(
Michael,
This does not apply as it is and your previous set of patches does not
seems to have made it. I never received it. Is it me or?
--
Julien Danjou
❱ http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adjust org-contacts-wl functions to used standards
2011-05-12 18:25 ` Julien Danjou
@ 2011-05-12 19:15 ` Michael Markert
2011-05-24 10:50 ` Carsten Dominik
0 siblings, 1 reply; 6+ messages in thread
From: Michael Markert @ 2011-05-12 19:15 UTC (permalink / raw)
To: Julien Danjou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On 12 May 2011, Julien Danjou wrote:
> On Thu, May 12 2011, Michael Markert wrote:
>
>> I missed a nasty bit: `org-contacts-wl-get-name-email' was not updated
>> and contained another bug.
>> :(
>
> Michael,
>
> This does not apply as it is and your previous set of patches does not
> seems to have made it. I never received it. Is it me or?
No, I forgot to CC you the patches, they only went to the list. My bad.
They are also on patchwork[1] and my org clone on github[2] if that's
easier for you.
Michael
Footnotes:
[1] starting with: http://patchwork.newartisans.com/patch/791/
[2] https://github.com/cofi/myOrg-Mode/tree/wl-contacts
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adjust org-contacts-wl functions to used standards
2011-05-12 19:15 ` Michael Markert
@ 2011-05-24 10:50 ` Carsten Dominik
2011-05-24 17:41 ` Michael Markert
0 siblings, 1 reply; 6+ messages in thread
From: Carsten Dominik @ 2011-05-24 10:50 UTC (permalink / raw)
To: Michael Markert; +Cc: Julien Danjou, emacs-orgmode
Hi Michael,
I did apply the patches, but had problems. Please verify that it came out right....
Thanks.
- Carsten
On May 12, 2011, at 9:15 PM, Michael Markert wrote:
> On 12 May 2011, Julien Danjou wrote:
>> On Thu, May 12 2011, Michael Markert wrote:
>>
>>> I missed a nasty bit: `org-contacts-wl-get-name-email' was not updated
>>> and contained another bug.
>>> :(
>>
>> Michael,
>>
>> This does not apply as it is and your previous set of patches does not
>> seems to have made it. I never received it. Is it me or?
>
> No, I forgot to CC you the patches, they only went to the list. My bad.
>
> They are also on patchwork[1] and my org clone on github[2] if that's
> easier for you.
>
> Michael
>
> Footnotes:
>
> [1] starting with: http://patchwork.newartisans.com/patch/791/
>
> [2] https://github.com/cofi/myOrg-Mode/tree/wl-contacts
- Carsten
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adjust org-contacts-wl functions to used standards
2011-05-24 10:50 ` Carsten Dominik
@ 2011-05-24 17:41 ` Michael Markert
0 siblings, 0 replies; 6+ messages in thread
From: Michael Markert @ 2011-05-24 17:41 UTC (permalink / raw)
To: Carsten Dominik; +Cc: Julien Danjou, emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
Hi Carsten,
On 24 May 2011, Carsten Dominik wrote:
>
> Hi Michael,
>
> I did apply the patches, but had problems. Please verify that it came out
> right....
>
> Thanks.
>
> - Carsten
Looks good to me. Thanks for merging. :)
Michael
> On May 12, 2011, at 9:15 PM, Michael Markert wrote:
>
>> On 12 May 2011, Julien Danjou wrote:
>>> On Thu, May 12 2011, Michael Markert wrote:
>>>
>>>> I missed a nasty bit: `org-contacts-wl-get-name-email' was not updated
>>>> and contained another bug.
>>>> :(
>>>
>>> Michael,
>>>
>>> This does not apply as it is and your previous set of patches does not
>>> seems to have made it. I never received it. Is it me or?
>>
>> No, I forgot to CC you the patches, they only went to the list. My bad.
>>
>> They are also on patchwork[1] and my org clone on github[2] if that's
>> easier for you.
>>
>> Michael
>>
>> Footnotes:
>>
>> [1] starting with: http://patchwork.newartisans.com/patch/791/
>>
>> [2] https://github.com/cofi/myOrg-Mode/tree/wl-contacts
>
> - Carsten
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-24 17:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-06 10:06 Adjust org-contacts-wl functions to used standards Michael Markert
2011-05-12 18:04 ` Michael Markert
2011-05-12 18:25 ` Julien Danjou
2011-05-12 19:15 ` Michael Markert
2011-05-24 10:50 ` Carsten Dominik
2011-05-24 17:41 ` Michael Markert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).