From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Trying to use a custom face for highlighting tags used in agenda filtering Date: Sun, 30 Oct 2011 01:39:38 +0200 Message-ID: <87mxcjtlj9.fsf@gnu.org> References: <80pqhjpkoy.fsf@somewhere.org> <801utyrv1o.fsf@somewhere.org> <87mxckyr8g.fsf@gnu.org> <80mxcja8u8.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:59659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKIUC-0003D1-CZ for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 19:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKIUA-0006a6-Tv for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 19:38:48 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:33810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKIUA-0006a1-Lc for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 19:38:46 -0400 Received: by wyg34 with SMTP id 34so5994927wyg.0 for ; Sat, 29 Oct 2011 16:38:45 -0700 (PDT) In-Reply-To: <80mxcja8u8.fsf@somewhere.org> (Sebastien Vauban's message of "Sat, 29 Oct 2011 21:36:31 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: emacs-orgmode@gnu.org Hi Sébastien, "Sebastien Vauban" writes: >> I've updated the patch using org-propertize instead of propertize > > OK, for better XEmacs support, if I understand well. Yes. >> and using a better default for the face :) > > Well, I wouldn't call org-default a better default, but that's fine with me. I > mean: if org-default is black for the majority of the people, they won't even > see that you can customize that aspect of the modeline (in a light > scheme). Well, org-default is *not* a good default, 'modeline is. I've pushed a fix for this. > So, I prefer some color (I chose orange) that everybody can customize, and > that makes everybody be aware of the tags used for filtering (in this case). > But, as said, I don't mind the default: I'll customize it anyway for my own > usage. One advantage of making the use of a face visible is to let people know they can change it. In this case, changing the weight or using a different color may be an option -- let's see if people come up with good ideas. >>> I'd like even to be able to put in one color the "positive" tags and in >>> another the "negative" ones, but that's above my current knowledge of >>> text-properties... >> >> Maybe you can start by replacing the 'identity function in the (mapconcat >> ...) by some (lambda (f) (if ...)) to check whether each tag filter starts >> with a + or a -. Just an idea. > > Just that I'm still to ignorant of the inner working of property list. But > it's nice to give me a hint. That could help me to quicklier come with a > working solution. Thanks for your time in digging into this! Best, -- Bastien