emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-map-entries broken?
@ 2012-03-19 14:17 Charles Sebold
  2012-03-19 19:49 ` Mike McLean
  0 siblings, 1 reply; 4+ messages in thread
From: Charles Sebold @ 2012-03-19 14:17 UTC (permalink / raw)
  To: emacs-orgmode

I think this patch may have broken org-map-entries for me:

e0072f79137bbfabdf848da6865d8e4de776a549 is the first bad commit
commit e0072f79137bbfabdf848da6865d8e4de776a549
Author: David Maus <dmaus@ictsoc.de>
Date:   Sun Mar 18 18:38:50 2012 +0100

    Require one or more spaces (+) between keyword and headline

    * org.el (org-scan-tags): Require one or more spaces (+) between
    keyword and headline.

    Otherwise the re will match a line like:

    * TODO@ Foobar

    And assumes the @ to be part of the headline.

    This fixes a glitch reported by Simon Thum in
    <4F53DEF7.8080604@gmx.de>.

    > Hi all,
    >
    > I have found some irritating behaviour, potentially a bug. I have a
    > block agenda which goes like:
    >
    > tags-todo "@home&TODO=\"TODO\"
    >
    > and it displays a certain org line that reads
    >
    > **** TODO_ state triggers
    >
    > Which is just a heading for dealing with TODO state triggers, and I
    > appended the _ as I don't want it to be a TODO.
    >
    > For example, the global TODO list and syntax highlighting does not
    > consider it a todo, but C-c a m TODO="TODO" does. TODO="T" does not,
    > so it's not very grave.
    >
    > Most likely, it's simply an inconsistency arising from not having a
    > real parser. I just wanted to report it here so it may get fixed.

:040000 040000 8f5974f2dd7cf5f0ad10db56d223ba09a6dbca80
624cee5569de7ef8f240ad75943be215bb823ccc M      lisp

---------------------------------------------------------------------------------

Try the following before and after this patch was applied, for a test result:

---------------------------------------------------------------------------------
* test one
* test two
* test three

  #+BEGIN_SRC emacs-lisp :results both
    (org-map-entries 'org-get-heading nil nil)
  #+END_SRC
---------------------------------------------------------------------------------

The results ought to be the three test headings in a table output.
After the patch it's blank.
--
Charles Sebold
Ego delendus sum

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: org-map-entries broken?
  2012-03-19 14:17 org-map-entries broken? Charles Sebold
@ 2012-03-19 19:49 ` Mike McLean
  2012-03-20  1:34   ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Mike McLean @ 2012-03-19 19:49 UTC (permalink / raw)
  To: Charles Sebold; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 2797 bytes --]

I can confirm this and add that it additionally breaks tag inheritance. I
first noticed that a org-collector code block that I've been using forever
was generating table that were way too long. My collector block includes
=:conds ( not (string-match-p "noexport" ALLTAGS)= and the extra results I
was getting all were from long trees tagged at the parent :no export:

I also have some Agenda custom views that use tag inheritance that broke at
the same time.

I reverted =e0072f79137bbfabdf848da6865d8e4de776a549= and both behaviors
corrected themselves.

Mike

On Monday, March 19, 2012, Charles Sebold <csebold@gmail.com> wrote:
> I think this patch may have broken org-map-entries for me:
>
> e0072f79137bbfabdf848da6865d8e4de776a549 is the first bad commit
> commit e0072f79137bbfabdf848da6865d8e4de776a549
> Author: David Maus <dmaus@ictsoc.de>
> Date:   Sun Mar 18 18:38:50 2012 +0100
>
>     Require one or more spaces (+) between keyword and headline
>
>     * org.el (org-scan-tags): Require one or more spaces (+) between
>     keyword and headline.
>
>     Otherwise the re will match a line like:
>
>     * TODO@ Foobar
>
>     And assumes the @ to be part of the headline.
>
>     This fixes a glitch reported by Simon Thum in
>     <4F53DEF7.8080604@gmx.de>.
>
>     > Hi all,
>     >
>     > I have found some irritating behaviour, potentially a bug. I have a
>     > block agenda which goes like:
>     >
>     > tags-todo "@home&TODO=\"TODO\"
>     >
>     > and it displays a certain org line that reads
>     >
>     > **** TODO_ state triggers
>     >
>     > Which is just a heading for dealing with TODO state triggers, and I
>     > appended the _ as I don't want it to be a TODO.
>     >
>     > For example, the global TODO list and syntax highlighting does not
>     > consider it a todo, but C-c a m TODO="TODO" does. TODO="T" does not,
>     > so it's not very grave.
>     >
>     > Most likely, it's simply an inconsistency arising from not having a
>     > real parser. I just wanted to report it here so it may get fixed.
>
> :040000 040000 8f5974f2dd7cf5f0ad10db56d223ba09a6dbca80
> 624cee5569de7ef8f240ad75943be215bb823ccc M      lisp
>
>
---------------------------------------------------------------------------------
>
> Try the following before and after this patch was applied, for a test
result:
>
>
---------------------------------------------------------------------------------
> * test one
> * test two
> * test three
>
>  #+BEGIN_SRC emacs-lisp :results both
>    (org-map-entries 'org-get-heading nil nil)
>  #+END_SRC
>
---------------------------------------------------------------------------------
>
> The results ought to be the three test headings in a table output.
> After the patch it's blank.
> --
> Charles Sebold
> Ego delendus sum
>
>

[-- Attachment #2: Type: text/html, Size: 3517 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: org-map-entries broken?
  2012-03-19 19:49 ` Mike McLean
@ 2012-03-20  1:34   ` Bastien
  2012-03-20  5:01     ` David Maus
  0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2012-03-20  1:34 UTC (permalink / raw)
  To: Mike McLean; +Cc: emacs-orgmode

Mike McLean <mike.mclean@pobox.com> writes:

> I reverted =e0072f79137bbfabdf848da6865d8e4de776a549= and both
> behaviors corrected themselves.

I reverted this commit both in maint (included in 7.8.06)
and master. 

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: org-map-entries broken?
  2012-03-20  1:34   ` Bastien
@ 2012-03-20  5:01     ` David Maus
  0 siblings, 0 replies; 4+ messages in thread
From: David Maus @ 2012-03-20  5:01 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, Mike McLean

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

At Tue, 20 Mar 2012 02:34:40 +0100,
Bastien wrote:
>
> Mike McLean <mike.mclean@pobox.com> writes:
>
> > I reverted =e0072f79137bbfabdf848da6865d8e4de776a549= and both
> > behaviors corrected themselves.
>
> I reverted this commit both in maint (included in 7.8.06)
> and master.

Thanks, I'll give a fix for the problem I tried to fix with this
commit a new shot.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: OpenPGP Digital Signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-03-20  5:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-19 14:17 org-map-entries broken? Charles Sebold
2012-03-19 19:49 ` Mike McLean
2012-03-20  1:34   ` Bastien
2012-03-20  5:01     ` David Maus

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).