emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: orgstuct++ does not lurk silently in the shadow
Date: Sun, 06 May 2012 17:47:14 +0200	[thread overview]
Message-ID: <87mx5ls459.fsf@gnu.org> (raw)
In-Reply-To: <878vh5s8nx.fsf@ucl.ac.uk> (Eric Fraga's message of "Sun, 6 May 2012 23:39:38 +0930")

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

Hi Eric,

Eric Fraga <e.fraga@ucl.ac.uk> writes:

> unfortunately, I still have problems.  I am using org completely up to
> date (a few minutes ago).  I do not turn orgstruct++-mode on
> automatically at all any more but instead turn it on manually by
>
>   M-x orgstruct++-mode RET
>
> once I'm in a Message buffer.
>
> I tried it just now, replying to your email as my test.  Turned on the
> mode, tried to fill the quoted text and it all got mixed up.  

You are using the exact same version of Gnus and Emacs than I do.
Unless you forgot to reload the correct (uncompiled?) version of
Org -- I barely dare suggesting this :) -- then this comes from 
something in your configuration.

But no matter where it comes from, we should fix it!

> Undid that.  Then went to the bottom and tried to insert a new line
> and got:
>
>   org-indent-line-function: Lisp nesting exceeds `max-lisp-eval-depth'

If you're certain you're loading Org correctly, please try the attached
patch and just tell me if the error disappears.

One possibility I can think of is that perhaps you turn on both
orgstruct-mode and orgstruct++-mode. In that case when orgstruct++-mode
will save the fill*/indent* variables from the _previous_ mode, it will
suppose they are the ones from message-mode, which will not be true and
will perhaps cause a loop.  The attached patch prevents such a loop.

> Turned off orgstruct++-mode (by M-x ... RET again) and filling of quoted
> text works fine as does normal writing.

This is already a progress against orgstruct++-mode as it worked before
... somewhat recomforting.

> I will try (tomorrow) to isolate this with emacs -Q but my problem is
> that my gnus configuration is really really messy and difficult to
> isolate.

We just need this:

C-x C-f ~/.gnus.el
M-x occur RET message*hook

Also check in your Emacs customization file.

HTH,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-org-indent-line-function.patch --]
[-- Type: text/x-patch, Size: 492 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index e7c42db..17a5bc2 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -20534,7 +20534,8 @@ If point is in an inline task, mark that task instead."
     (org-move-to-column column)
     (when (and orgstruct-is-++ (eq pos (point)))
       (org-let org-fb-vars
-	'(indent-according-to-mode)))))
+	'(or (eq indent-line-function 'org-indent-line-function)
+	     (indent-according-to-mode))))))
 
 (defun org-indent-drawer ()
   "Indent the drawer at point."

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

  parent reply	other threads:[~2012-05-06 15:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  7:08 Christopher Schmidt
2012-03-08 13:38 ` orgstruct++ does not lurk silently in the shadow (was: orgstuct++ does not lurk silently in the shadow) Christopher Schmidt
2012-04-25  7:44 ` orgstuct++ does not lurk silently in the shadow Eric Fraga
2012-04-26 10:42   ` Bastien
2012-04-29  6:40     ` Eric Fraga
2012-04-29  6:48       ` Eric Fraga
2012-04-29  8:38       ` Bastien
2012-04-29 11:05     ` Christopher Schmidt
2012-04-29 12:27       ` Christopher Schmidt
2012-05-01 17:43       ` Bastien
2012-05-03  9:56         ` Eric Fraga
2012-05-03 12:28           ` Bastien
2012-05-03 12:58             ` Nicolas Goaziou
2012-05-03 13:12               ` Bastien
2012-05-03 13:17                 ` Nicolas Goaziou
2012-05-03 13:45                   ` Bastien
2012-05-03 15:53                     ` Nicolas Goaziou
2012-05-05 13:46               ` Bastien
2012-05-05 15:51                 ` Nicolas Goaziou
2012-05-05 16:18                   ` Bastien
2012-05-05 16:19                     ` Nicolas Goaziou
2012-05-05 16:22                   ` Bastien
2012-05-05 16:30                     ` Nicolas Goaziou
2012-05-06  8:07                       ` Bastien
2012-05-06 14:09                         ` Eric Fraga
2012-05-06 14:27                           ` Thorsten Jolitz
2012-05-06 15:47                           ` Bastien [this message]
2012-05-07  4:23                             ` Eric S Fraga
2012-05-08 12:31                               ` Bastien
2012-05-08 23:54                                 ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx5ls459.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    --subject='Re: orgstuct++ does not lurk silently in the shadow' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).