From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] New LaTeX exporter, switch for hypersetup Date: Thu, 10 Jan 2013 22:22:24 +0100 Message-ID: <87mwwg20of.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtPdq-0005ra-GI for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 16:26:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtPdp-0005Ba-2e for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 16:26:26 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:58834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtPdo-0005BN-TP for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 16:26:25 -0500 Received: by mail-we0-f170.google.com with SMTP id r1so509916wey.15 for ; Thu, 10 Jan 2013 13:26:24 -0800 (PST) In-Reply-To: (Thomas S. Dye's message of "Wed, 09 Jan 2013 09:33:09 -1000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Thomas S. Dye" Cc: Org-mode Hello, tsd@tsdye.com (Thomas S. Dye) writes: Thanks for your patch. A few comments below. > I don't think I fully understand how :options-alist works. With the > attached patch I was expecting to be able to use #+LATEX_HYPER: nil, but > this didn't work for me. Keywords values are either a string or a list of strings. In this case, #+LATEX_HYPER: nil means the value is "nil", not nil. You still can test it with `org-not-nil' function. > :options-alist ((:date "DATE" nil org-e-latex-date-format t) > (:latex-class "LATEX_CLASS" nil org-e-latex-default-class t) > (:latex-class-options "LATEX_CLASS_OPTIONS" nil nil t) > - (:latex-header-extra "LATEX_HEADER" nil nil newline))) > + (:latex-header-extra "LATEX_HEADER" nil nil newline) > + (:with-hyper "LATEX_HYPER" "texht" t t) I suggest to use :latex-hyperref-p or :latex-with-hyperref instead of :with-hyper, since this is back-end specific. Moreover, IMO, it doesn't make sense to provide a way to set it both through the #+OPTIONS: line and with a "LATEX_HYPER" keyword. You should choose your side. Also, you may want to use a global defcustom for the default value, instead of setting it to t, i.e. `org-e-latex-with-hyperref'. > + )) Please do not leave parenthesis on a line of their own. Regards, -- Nicolas Goaziou