emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "浅井 政太郎" <guicho2.71828@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch for org-md, with optional GFM source code output
Date: Sun, 05 May 2013 19:49:14 +0200	[thread overview]
Message-ID: <87mws9fhb9.fsf@gmail.com> (raw)
In-Reply-To: <51869062.7010701@gmail.com> ("浅井 政太郎"'s message of "Mon, 06 May 2013 02:01:22 +0900")

Hello,

浅井 政太郎 <guicho2.71828@gmail.com> writes:

> Not sure this will be accepted,
> but personally it is very useful when I
> output org to md and publish it with octopress.

Thanks for your patch. Though, the very point of ox-md.el is to produce
vanilla flavour, not Octopress' or Github's.

You could create a derived back-end from it instead, e.g.
ox-md-octopress.el and request to put it in contrib directory. See
`org-export-define-derived-backend' for details.

> +(defun %string-prop (prop block)
> +  (let ((prop (org-element-property prop block)))
> +    (if prop prop "")))

This is not needed (and the namespace used is wrong: it should be
prefixed with `org-md-....' since there's no module in elisp). I suggest
to use `org-string-nw-p' instead.

> +(defun org-md-src-block (src-block contents info)
> +  "Transcode SRC-BLOCK element into Markdown format.
> +CONTENTS is nil.  INFO is a plist used as a communication
> +channel."
> +  (case org-md-src-style
> +    (indent (org-md-example-block src-block contents info))
> +    (github-flavored
> +     (concatenate

`concat' is sufficient here.


Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2013-05-05 17:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-05 17:01 Patch for org-md, with optional GFM source code output 浅井 政太郎
2013-05-05 17:49 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mws9fhb9.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=guicho2.71828@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).