emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Incorrect sum of times in table
Date: Mon, 01 Jul 2013 23:22:20 +0200	[thread overview]
Message-ID: <87mwq6ugab.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87ppv2atvf.fsf@gmail.com> (Nick Dokos's message of "Mon, 01 Jul 2013 16:49:08 -0400")

Hi Nick,

Nick Dokos <ndokos@gmail.com> writes:

> I think you mean C-c +.
>
> The problem is that these things are calculated as decimal hours, using
> floating point arithmetic and you get truncation towards 0 when the
> value is printed out as an integer. The format in org-table-sum is
>
>     (format "%d:%02d:%02d" h m s)
>
> but s is 0.9999...  and it gets formatted as 0.
>
> It might be better to use
>
>     (format "%.0f:%02.0f:%02.0f" h m s)
>
> i.e. as floating point with no places after the decimal point
> (in which case the decimal point does not seem to be output).
> But there may be other problems that I have not thought of.
> It might be even better to round the floating point number to
> the nearest integer and use %d formats instead:
>
>     (format "%d:%02d:%02d" (round h) (round m) (round s))

Both solutions work -- we don't need to fear other problems here,
`org-table-sum' is pretty isolated, so I'd say "please go ahead!
and fix this in maint.

Thanks,

-- 
 Bastien

next prev parent reply	other threads:[~2013-07-01 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 17:38 Incorrect sum of times in table Paul Stansell
2013-07-01 20:49 ` Nick Dokos
2013-07-01 21:22   ` Bastien [this message]
2013-07-03  8:18     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwq6ugab.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=ndokos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).